From: Quentin Perret <qperret@google.com>
To: Vincent Donnefort <vincent.donnefort@arm.com>
Cc: peterz@infradead.org, rjw@rjwysocki.net, viresh.kumar@linaro.org,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
ionela.voinescu@arm.com, lukasz.luba@arm.com,
dietmar.eggemann@arm.com
Subject: Re: [PATCH v2 1/3] PM / EM: Fix inefficient state detection
Date: Tue, 25 May 2021 09:50:43 +0000 [thread overview]
Message-ID: <YKzIc5/j27q3XWf3@google.com> (raw)
In-Reply-To: <1621616064-340235-2-git-send-email-vincent.donnefort@arm.com>
On Friday 21 May 2021 at 17:54:22 (+0100), Vincent Donnefort wrote:
> Currently, a debug message is printed if an inefficient state is detected
> in the Energy Model. Unfortunately, it won't detect if the first state is
> inefficient or if two successive states are. Fix this behavior.
Right, and the first OPPs in the table often are the inefficient ones
(because e.g. they share the same voltage), so this definitely wants
fixing. I wonder if this wants a Fixes: tag even?
> Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
Reviewed-by: Quentin Perret <qperret@google.com>
Thanks,
Quentin
next prev parent reply other threads:[~2021-05-25 9:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 16:54 [PATCH v2 0/3] EM / PM: Inefficient OPPs Vincent Donnefort
2021-05-21 16:54 ` [PATCH v2 1/3] PM / EM: Fix inefficient state detection Vincent Donnefort
2021-05-24 12:41 ` Lukasz Luba
2021-05-25 9:50 ` Quentin Perret [this message]
2021-05-21 16:54 ` [PATCH v2 2/3] PM / EM: Extend em_perf_domain with a flag field Vincent Donnefort
2021-05-24 12:44 ` Lukasz Luba
2021-05-25 9:54 ` Quentin Perret
2021-05-21 16:54 ` [PATCH v2 3/3] PM / EM: Skip inefficient OPPs Vincent Donnefort
2021-05-24 12:55 ` Lukasz Luba
2021-05-25 8:48 ` Peter Zijlstra
2021-05-25 9:21 ` Vincent Donnefort
2021-05-25 10:00 ` Vincent Donnefort
2021-05-28 5:09 ` Viresh Kumar
2021-06-01 8:47 ` Vincent Donnefort
2021-06-01 8:56 ` Viresh Kumar
2021-06-01 9:07 ` Quentin Perret
2021-06-01 9:13 ` Viresh Kumar
2021-05-25 9:33 ` Quentin Perret
2021-05-25 9:46 ` Vincent Donnefort
2021-05-25 11:03 ` Lukasz Luba
2021-05-25 13:06 ` Quentin Perret
2021-05-25 13:34 ` Lukasz Luba
2021-05-25 9:47 ` Vincent Donnefort
2021-05-28 5:04 ` Viresh Kumar
2021-05-28 9:00 ` Lukasz Luba
2021-05-26 3:47 ` [PATCH v2 0/3] EM / PM: Inefficient OPPs Viresh Kumar
2021-05-26 8:56 ` Lukasz Luba
2021-05-26 9:33 ` Viresh Kumar
2021-05-27 7:13 ` Lukasz Luba
2021-05-26 9:01 ` Vincent Donnefort
2021-05-26 9:38 ` Viresh Kumar
2021-05-26 9:39 ` Viresh Kumar
2021-05-26 10:24 ` Lukasz Luba
2021-05-26 10:39 ` Lukasz Luba
2021-05-26 11:50 ` Lukasz Luba
2021-05-26 13:49 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKzIc5/j27q3XWf3@google.com \
--to=qperret@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox