From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B125C49EA5 for ; Tue, 8 Jun 2021 19:23:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81B35613BD for ; Tue, 8 Jun 2021 19:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239703AbhFHTZC (ORCPT ); Tue, 8 Jun 2021 15:25:02 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:36385 "EHLO mail-qk1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237743AbhFHTMt (ORCPT ); Tue, 8 Jun 2021 15:12:49 -0400 Received: by mail-qk1-f171.google.com with SMTP id i68so17722239qke.3 for ; Tue, 08 Jun 2021 12:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e2e0nbp6c2IsfH6eGt//ttu3w5sssACWJPEc3XNG8Pg=; b=ZuVv7faqXk8C6mPlOUqEVmcACCTQ98XntewTLfiQpaRXvpWy3yMkqZ/g4vlgpHKWTr BU++vbZzx31e8JWMGSzMDOWCFzzuIWLE9vd+hmKUEC9Z/K8NNBBuPcON22xcsInqEvin JwOr0H3zeM9HpVNQvdI93dkzIS9dRVLUxHYZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e2e0nbp6c2IsfH6eGt//ttu3w5sssACWJPEc3XNG8Pg=; b=P2ozQxNbMf+50jMcIZO/Gua5fKVg9jUr2OaNFcxRk+R7PduiT+TqsCJtHuEb8DELJn hW75VAwJuHT4pFbdcKhxwYOAVxefhys36HL7/hB/5ZMREUNoee2Vpi6g/8GEv8Mcptm1 IuyONklxORFaUt4BxomUn54OG1yWwAqW22tqeTa1HP4YYqDuEYUNFe8PqrmdGrPaeaxE 1GcGD48UriVAt9yurWBrspYNun5qWplSlgRsMqTkC2Wr5YCOCUiLB5X9Be63uxfOAKgC jG0wklCG4O/QjUgVt7oW7oPJDtZ3qHjZ/krYEhhWQYzQaDdYfN51STmn9ZOxRUs5LkEp dJgg== X-Gm-Message-State: AOAM5316SCXsMKEjbTuII8FCy9mJKOL/y1+8aBokNINB8Ss6wjJxBZpB Qxnps5UJAJdevyoEOPziQYZgrQ== X-Google-Smtp-Source: ABdhPJzGGFkMkAQrKfA4GfIgcv+7CvWTcS+TMnx5Do27XYGAhGeD1dAtdseitLLXFqNiE8ZI9EdaVA== X-Received: by 2002:a37:a115:: with SMTP id k21mr19468304qke.255.1623179378363; Tue, 08 Jun 2021 12:09:38 -0700 (PDT) Received: from localhost ([2620:15c:6:411:e3b6:6e12:5019:bd58]) by smtp.gmail.com with ESMTPSA id d18sm3483912qkg.129.2021.06.08.12.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 12:09:37 -0700 (PDT) Date: Tue, 8 Jun 2021 15:09:37 -0400 From: Joel Fernandes To: Beata Michalska Cc: Valentin Schneider , Quentin Perret , Peter Zijlstra , LKML , Qais Yousef , Vincent Guittot , Viresh Kumar Subject: Re: iowait boost is broken Message-ID: References: <20210607191031.GA12489@e120325.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607191031.GA12489@e120325.cambridge.arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Beata, On Mon, Jun 07, 2021 at 08:10:32PM +0100, Beata Michalska wrote: > Hi Joel, > > Thanks for sending this out. Np, thanks for replying. > On Mon, Jun 07, 2021 at 12:19:01PM -0400, Joel Fernandes wrote: > > Hi all, > > Looks like iowait boost is completely broken upstream. Just > > documenting my findings of iowait boost issues: > > > I wouldn't go as far to state that it is completely broken. Rather that > the current sugov implementation for iowait boosting is not meeting > the expectations and I believe this should be clarified first. More on those > expectations below. > > 1. If a CPU requests iowait boost in a cluster, another CPU can go > > ahead and reset very quickly it since it thinks there's no new request > > for the iowait boosting CPU > So the 'boosting' value is being tracked per CPU, so each core in a cluster > will have it's own variant of that. When calculating the shared freq for > the cluster, sugov will use max utilization reported on each core, including > I/O boost. Now, if there is no pending request for boosting on a given core > at the time of calling sugov_iowait_apply, the current 'boost' will be > reduced, but only this one and that will not affect boost values on remaining > CPUs. It means that there was no task waking up on that particular CPU after > waiting on I/O request. So I would say it's fine. Unless I am misunderstanding > your case ? Yes, but consider the case where the I/O is slow on one CPU (call it X) so say IO wait takes 2 milliseconds. Now another CPU (call it Y) is continuiously making cpufreq requests much faster than that. Also consider that the slow CPU X is doing back to back I/O request and has consecutive I/O sleep time (no other sleep, just I/O sleep). What you'll see is the CPU X's boost always stays at _MIN boost when it wakes up because Y reset it to 0 in the meanwhile. So the boost never accumulates. Does that make sense? I would say that the I/O CPU should have a 'doubling' of boost. Probably the issue can be solved by making rate_limit_us longer than the iowait time. But that seems like a hack and would likely cause other issues. > > 2. If the iowait is longer than a tick, then successive iowait boost > > doubling does not happen. So heavy I/O waiting code never gets a > > boost. > This might indeed be an issue. What's more: the fact that boosting is applied > per core, any migration will disregard the boosting applied so far, so > it might start increasing the freq on 'new' CPU from scratch. > Might, as sugov (and the I/O boosting) has no notion of the source of boosting > request so it might end up on a core that has already lifted I/O boost. > This also means, that having different small tasks, waking up from > I/O within the mentioned TICK_NSEC time window might drive the frequency to max > even though those would be sporadic wakeups. Things get slightly > cumbersome as increasing the boost does not necessarily result in the freq > change, so the above mentioned case would need proper timing but it is possible. > Also the boost value will not get doubled unless previous one has been applied. > This might result in misalignment between task wake-ups/placement and sugov's > freq changes. Agreed, there are many issues, thanks for highlighting. > > 3. update_load_avg() is triggered right after the the iowait boost > > request which makes another cpufreq update request, this request is a > > non-iowait boost one so it ends up resetting the iowait boost request > > (in the same path!). > Not necessarily - this is guarded by the TICK_NSEC you have mentioned: > in > sugov_iowait_reset { > ... > if (delta_ns <= TICK_NSEC) > return; > ... > } > So for the particular call sequence the boost should not get reset. > Another problem is when the non-I/O bound tasks triggers the update > after the TICK_NSEC has elapsed and before the frequency change is done. > (see sugov_should_update_freq ) Oh yeah. You are quite right on this particular issue. I agree it shouldn't reset. So I wonder what I was seeing for #3 then... Hopefully delta_ns can be trusted.. > > 4. Same as #3 but due the update_blocked_averages from new idle balance path. > > > > Here is a patch that tries to address these problems and I see better > > cpufreq boosting happening, however it is just a test broken patch to > > highlight the issues: > > https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/commit/?h=sched/5.4/iowait-boost-debug-1&id=3627d896d499d168fef9a388e5d6b3359acc3423 > > > > I think we ought to rewrite the whole mess instead of fixing it since > > a lot has changed in scheduler code over time it feels. Beata is > > working on rewriting the whole iowait boost infra, I am glad she has > > started the work on this and looking forward to helping with the > > patches. > > > So back to the expectations. > The main problem, as I see it, is what do we actually want to achieve with > the I/O boosting? Is it supposed to compensate the time lost while waiting > for the I/O request to be completed or is is supposed to optimize the rate > at which I/O requests are being made. Do we want to boost I/O bound tasks by > default, no limits applied or should we care about balancing performance > vs power ? And unless those expectations are clearly stated, we might not > get too far with any changes, really. Yeah part of the problem its not clear how much boost is 'ideal'. However, not having any boost at all or a boost too low for heavy I/O seems a clear issues. I guess some boost will be better than no boost. But I agree its hard to design an algorithm that fits everything. > Smth that I do agree with is what has been suggested few times by Quentin, > to make the I/O boosting being a per-task feature, not per-core, and that is > smth I have been experimenting with. Yeah I agree with that too. Thanks, Joel