From: Heiko Carstens <hca@linux.ibm.com>
To: Barry Song <song.bao.hua@hisilicon.com>
Cc: akpm@linux-foundation.org, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, gor@linux.ibm.com,
borntraeger@de.ibm.com, naveen.n.rao@linux.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
mhiramat@kernel.org, linux-s390@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2] kprobes: remove duplicated strong free_insn_page in x86 and s390
Date: Mon, 7 Jun 2021 12:57:53 +0200 [thread overview]
Message-ID: <YL37sTAUIfDulsDE@osiris> (raw)
In-Reply-To: <20210607091854.31580-1-song.bao.hua@hisilicon.com>
On Mon, Jun 07, 2021 at 09:18:54PM +1200, Barry Song wrote:
> free_insn_page() in x86 and s390 are same with the common weak function
> in kernel/kprobes.c.
> Plus, the comment "Recover page to RW mode before releasing it" in x86
> seems insensible to be there since resetting mapping is done by common
> code in vfree() of module_memfree().
> So drop these two duplicated strong functions and related comment, then
> mark the common one in kernel/kprobes.c strong.
>
> Cc: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
> -v2:
> remove free_insn_page in s390 as well and remove the __weak in common
> code according to Christoph's comment;
>
> arch/s390/kernel/kprobes.c | 5 -----
> arch/x86/kernel/kprobes/core.c | 6 ------
> kernel/kprobes.c | 2 +-
> 3 files changed, 1 insertion(+), 12 deletions(-)
For the s390 part:
Acked-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2021-06-07 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 9:18 [PATCH v2] kprobes: remove duplicated strong free_insn_page in x86 and s390 Barry Song
2021-06-07 9:30 ` Christoph Hellwig
2021-06-07 10:57 ` Heiko Carstens [this message]
2021-06-07 12:32 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL37sTAUIfDulsDE@osiris \
--to=hca@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=song.bao.hua@hisilicon.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).