From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wenli Looi <wlooi@ucalgary.ca>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Fix uninitialized variable
Date: Mon, 7 Jun 2021 11:23:22 +0200 [thread overview]
Message-ID: <YL3lih8OqGOLjVBf@kroah.com> (raw)
In-Reply-To: <20210607083316.GO1955@kadam>
On Mon, Jun 07, 2021 at 11:33:17AM +0300, Dan Carpenter wrote:
> Greg asked about struct holes and the answer is "= {}" will zero out
> struct holes but it's not important in this case. The "= {}" is a GCC
> extension for zeroing structs and it's not part of the C standard.
> The struct has a kernel pointer in it so we had better not be shairing
> it to user space.
I thought we proved that "= {}" will _NOT_ zero out holes in structures.
Or did we really prove that? I can't remember now, do you?
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-07 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 7:00 [PATCH] staging: rtl8723bs: Fix uninitialized variable Wenli Looi
2021-06-06 7:13 ` Greg Kroah-Hartman
2021-06-06 7:51 ` Wenli Looi
2021-06-06 8:00 ` Fabio M. De Francesco
2021-06-06 8:09 ` Wenli Looi
2021-06-06 8:45 ` Fabio M. De Francesco
2021-06-06 18:46 ` [PATCH v2] " Wenli Looi
2021-06-07 8:35 ` Dan Carpenter
2021-06-07 8:46 ` Dan Carpenter
2021-06-08 6:35 ` Wenli Looi
2021-06-07 8:33 ` [PATCH] " Dan Carpenter
2021-06-07 9:23 ` Greg Kroah-Hartman [this message]
2021-06-07 10:43 ` Dan Carpenter
2021-06-08 6:46 ` [PATCH] staging: rtl8723bs: Fix uninitialized variables Wenli Looi
2021-06-08 7:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL3lih8OqGOLjVBf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=wlooi@ucalgary.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox