From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 684C1C47094 for ; Mon, 7 Jun 2021 12:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 485426121D for ; Mon, 7 Jun 2021 12:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbhFGM5o (ORCPT ); Mon, 7 Jun 2021 08:57:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbhFGM5m (ORCPT ); Mon, 7 Jun 2021 08:57:42 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B41C061766 for ; Mon, 7 Jun 2021 05:55:51 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 66702391; Mon, 7 Jun 2021 14:55:48 +0200 (CEST) Date: Mon, 7 Jun 2021 14:55:47 +0200 From: Joerg Roedel To: Robin Murphy Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jussi Maki Subject: Re: [PATCH] iommu/amd: Tidy up DMA ops init Message-ID: References: <665db61e23ff8d54ac5eb391bef520b3a803fcb9.1622727974.git.robin.murphy@arm.com> <781da5b3-4856-9a76-d803-51800dec6033@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <781da5b3-4856-9a76-d803-51800dec6033@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 06:35:17PM +0100, Robin Murphy wrote: > For the sake of justifying this as "fix" rather than "cleanup", you may as > well use the flush queue commit cited in the patch log - I maintain there's > nothing technically wrong with that commit itself, but it is the point at > which the underlying issue becomes worth fixing due to how they interact ;) Okay :) I added: Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE") Regards, Joerg