From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
wsa@kernel.org
Subject: Re: [PATCH v2 1/3] units: Add SI metric prefix definitions
Date: Mon, 7 Jun 2021 19:55:42 +0300 [thread overview]
Message-ID: <YL5PjhvfTXhUavSa@smile.fi.intel.com> (raw)
In-Reply-To: <e84d2094a6fc3c827e157b325addce4aa10b871f.camel@perches.com>
On Mon, Jun 07, 2021 at 09:00:41AM -0700, Joe Perches wrote:
> On Mon, 2021-06-07 at 18:57 +0300, Andy Shevchenko wrote:
> > On Mon, Jun 07, 2021 at 08:43:02AM -0700, Joe Perches wrote:
> > > On Mon, 2021-06-07 at 18:23 +0300, Andy Shevchenko wrote:
> > > > Sometimes it's useful to have well-defined SI metric prefix to be used
> > > > to self-describe the formulas or equations.
> -=
> > > The only use of any of these seems to be:
> > >
> > > sound/pcmcia/vx/vxp_ops.c: [VX_MICRO] = 0x0c, // MICRO
> > > sound/pcmcia/vx/vxp_ops.c: vx_outb(chip, MICRO, level);
> > > sound/pcmcia/vx/vxp_ops.c: vx_outb(chip, MICRO, vx_compute_mic_level(chip->mic_level));
> > >
> > > and these vx_outb uses are themselves macros that prepend VX_ to the 2nd arg.
> >
> > Is it a real issue there?
>
> No, it's all good.
Thanks for confirming!
So, I will send v3 (I guess tomorrow) with L->UL and LL accordingly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-07 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:23 [PATCH v2 1/3] units: Add SI metric prefix definitions Andy Shevchenko
2021-06-07 15:23 ` [PATCH v2 2/3] i2c: designware: Use DIV_ROUND_CLOSEST() macro Andy Shevchenko
2021-06-07 15:23 ` [PATCH v2 3/3] i2c: designware: Fix indentation in the header Andy Shevchenko
2021-06-07 15:43 ` [PATCH v2 1/3] units: Add SI metric prefix definitions Joe Perches
2021-06-07 15:57 ` Andy Shevchenko
2021-06-07 16:00 ` Joe Perches
2021-06-07 16:55 ` Andy Shevchenko [this message]
2021-06-07 19:09 ` Joe Perches
2021-06-08 8:42 ` Jarkko Nikula
2021-07-12 14:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL5PjhvfTXhUavSa@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox