public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: 8250_omap: Fix possible interrupt storm
Date: Fri, 28 May 2021 11:00:30 +0200	[thread overview]
Message-ID: <YLCxLvcm/yG9+GE3@kroah.com> (raw)
In-Reply-To: <e5b35370-bf2d-7295-e2fd-9aee5bbc3296@ti.com>

On Fri, May 28, 2021 at 11:41:36AM +0530, Vignesh Raghavendra wrote:
> Hi,
> 
> On 5/28/21 11:09 AM, Tony Lindgren wrote:
> > Hi Greg, Vignesh & Jan,
> > 
> > * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [210513 14:17]:
> >> On Tue, May 11, 2021 at 08:49:55PM +0530, Vignesh Raghavendra wrote:
> >>> It is possible that RX TIMEOUT is signalled after RX FIFO has been
> >>> drained, in which case a dummy read of RX FIFO is required to clear RX
> >>> TIMEOUT condition. Otherwise, RX TIMEOUT condition is not cleared
> >>> leading to an interrupt storm
> >>>
> >>> Cc: stable@vger.kernel.org
> >>
> >> How far back does this need to go?  What commit id does this fix?  What
> >> caused this to just show up now vs. previously?
> 
> Sorry, I missed this reply. Issue was reported on AM65x SoC with custom
> test case from Jan Kiszka that stressed UART with rapid baudrate changes
> from 9600 to 4M along with data transfer.
> 
> Based on the condition that led to interrupt storm, I inferred it to
> affect all SoCs with 8250 OMAP UARTs. But that seems thats not the best
> idea as seen from OMAP3 regression.
> 
> Greg,
> 
> Could you please drop the patch? Very sorry for the inconvenience..

Now reverted, thanks.

greg k-h

  reply	other threads:[~2021-05-28  9:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 15:19 [PATCH] serial: 8250: 8250_omap: Fix possible interrupt storm Vignesh Raghavendra
2021-05-13 14:17 ` Greg Kroah-Hartman
2021-05-28  5:39   ` Tony Lindgren
2021-05-28  6:11     ` Vignesh Raghavendra
2021-05-28  9:00       ` Greg Kroah-Hartman [this message]
2021-06-22  6:15       ` Jan Kiszka
2021-06-22  6:23         ` Vignesh Raghavendra
2021-07-12 20:27           ` andy
2021-07-13  8:54             ` Vignesh Raghavendra
2021-07-13  9:09               ` Andy Shevchenko
2021-07-13  9:13               ` Andy Shevchenko
2021-07-27 10:39                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLCxLvcm/yG9+GE3@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jan.kiszka@siemens.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox