Re: [PATCHv3 3/5] dt-bindings: misc: ge-achc: Convert to DT schema format

Rob Herring
2021-05-28T16:22:04Z

On Fri, 28 May 2021 13:33:45 +0200, Sebastian Reichel wrote:
> Convert the binding to DT schema format. Also update the binding
> to fix shortcomings
>
> * Add "nxp,kinetis-k20" fallback compatible
> * add programming SPI interface and reset GPIO
> * add main clock
> * add voltage supplies
> * drop spi-max-frequency from required properties,
> driver will setup max. frequency
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../devicetree/bindings/misc/ge-achc.txt | 26 -------
> .../devicetree/bindings/misc/ge-achc.yaml | 67 +++++++++++++++++++
> 2 files changed, 67 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/misc/ge-achc.txt
> create mode 100644 Documentation/devicetree/bindings/misc/ge-achc.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/ge-achc.yaml: properties:reg:minItems: False schema does not allow 2
hint: "minItems/maxItems" equal to the "items" list length are not necessary
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/ge-achc.yaml: properties:reg:maxItems: False schema does not allow 2
hint: "minItems/maxItems" equal to the "items" list length are not necessary
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/ge-achc.yaml: ignoring, error in schema: properties: reg: minItems
warning: no schema found in file: ./Documentation/devicetree/bindings/misc/ge-achc.yaml
Documentation/devicetree/bindings/misc/ge-achc.example.dt.yaml:0:0: /example-0/spi/spi@1: failed to match any schema with compatible: ['ge,achc', 'nxp,kinetis-k20']
Documentation/devicetree/bindings/misc/ge-achc.example.dt.yaml:0:0: /example-0/spi/spi@1: failed to match any schema with compatible: ['ge,achc', 'nxp,kinetis-k20']

See https://patchwork.ozlabs.org/patch/1485219

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.