From: Stephan Gerhold <stephan@gerhold.net>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Anibal Limon <anibal.limon@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: apq8016-sbc: Update modem and WiFi firmware path
Date: Tue, 1 Jun 2021 11:05:17 +0200 [thread overview]
Message-ID: <YLX4TfuxEnjQ3fhi@gerhold.net> (raw)
In-Reply-To: <20210531224453.783218-1-bjorn.andersson@linaro.org>
On Mon, May 31, 2021 at 03:44:53PM -0700, Bjorn Andersson wrote:
> The firmware for the modem and WiFi subsystems platform specific and is
> signed with a OEM specific key (or a test key). In order to support more
> than a single device it is therefor not possible to rely on the default
> path and stash these files directly in the firmware directory.
>
> This has already been addressed for other platforms, but the APQ8016 SBC
> (aka db410c) was never finished upstream.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
As far as I can tell,
"[PATCH 2/5] wcn36xx: Allow firmware name to be overridden by DT"
was never applied so with this patch DB410c fails to request the
"qcom/msm8916/WCNSS_qcom_wlan_nv.bin" firmware. Perhaps you need to
resend that one or poke whoever is responsible to apply that.
Once the wcn36xx patch was applied somewhere:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Tested-by: Stephan Gerhold <stephan@gerhold.net>
Thanks,
Stephan
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++++++++
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 6aef0c2e4f0a..448e3561ef63 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -305,6 +305,12 @@ &mdss {
> status = "okay";
> };
>
> +&mpss {
> + status = "okay";
> +
> + firmware-name = "qcom/msm8916/mba.mbn", "qcom/msm8916/modem.mbn";
> +};
> +
> &pm8916_resin {
> status = "okay";
> linux,code = <KEY_VOLUMEDOWN>;
> @@ -312,6 +318,8 @@ &pm8916_resin {
>
> &pronto {
> status = "okay";
> +
> + firmware-name = "qcom/msm8916/wcnss.mbn";
> };
>
> &sdhc_1 {
> @@ -394,6 +402,10 @@ &wcd_codec {
> qcom,mbhc-vthreshold-high = <75 150 237 450 500>;
> };
>
> +&wcnss_ctrl {
> + firmware-name = "qcom/msm8916/WCNSS_qcom_wlan_nv.bin";
> +};
> +
> /* Enable CoreSight */
> &cti0 { status = "okay"; };
> &cti1 { status = "okay"; };
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 4f06c0a9c425..6abe0f8edb55 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1738,7 +1738,7 @@ smd-edge {
>
> label = "pronto";
>
> - wcnss {
> + wcnss_ctrl: wcnss {
> compatible = "qcom,wcnss";
> qcom,smd-channels = "WCNSS_CTRL";
>
> --
> 2.29.2
>
prev parent reply other threads:[~2021-06-01 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 22:44 [PATCH v2] arm64: dts: qcom: apq8016-sbc: Update modem and WiFi firmware path Bjorn Andersson
2021-06-01 9:05 ` Stephan Gerhold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLX4TfuxEnjQ3fhi@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=anibal.limon@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox