From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ricardo Ribalda <ribalda@chromium.org>,
Tomasz Figa <tfiga@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5 0/5] media: uvcvideo: implement UVC 1.5 ROI
Date: Tue, 1 Jun 2021 17:46:50 +0900 [thread overview]
Message-ID: <YLXz+r8PkKx1VMVc@google.com> (raw)
In-Reply-To: <8583ed26-ef35-3341-5058-32dbf219d10c@xs4all.nl>
On (21/05/26 12:38), Hans Verkuil wrote:
> Hi Sergey,
>
> On 01/05/2021 10:19, Sergey Senozhatsky wrote:
> > Hello,
> >
> > This patch set implements UVC 1.5 ROI using v4l2_selection API.
> >
> > v5:
> > -- fixed UAPI typo: STABILIXATION
> > -- moved V4L2_CID_REGION_OF_INTEREST_AUTO to V4L2_CID_CAMERA_CLASS_BASE+36
> > -- added more comments (Ricardo)
> > -- added V4L2_CID_REGION_OF_INTEREST_AUTO to v4l2_ctrl_get_name() (Ricardo)
> >
> > Sergey Senozhatsky (5):
> > media: v4l UAPI: add ROI selection targets
>
> As mentioned in my reply to v4 0/5, I am quite strongly opposed to using the
> Selection API for this as opposed to using controls. Unless someone can provide
> strong arguments for using the Selection API, I am inclined to reject this.
>
> Sorry about that, I probably should have been reviewing this series sooner.
Hans, any suggestions regarding the UVCs GET_CUR, GET_DEF, GET_MIN/MAX
requests handling?
next prev parent reply other threads:[~2021-06-01 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 8:19 [PATCHv5 0/5] media: uvcvideo: implement UVC 1.5 ROI Sergey Senozhatsky
2021-05-01 8:19 ` [PATCHv5 1/5] media: v4l UAPI: add ROI selection targets Sergey Senozhatsky
2021-05-01 8:19 ` [PATCHv5 2/5] media: v4l UAPI: document " Sergey Senozhatsky
2021-05-01 8:19 ` [PATCHv5 3/5] media: uvcvideo: add ROI auto controls Sergey Senozhatsky
2021-05-01 8:20 ` [PATCHv5 4/5] media: v4l UAPI: document ROI auto_controls Sergey Senozhatsky
2021-05-01 8:20 ` [PATCHv5 5/5] media: uvcvideo: add UVC 1.5 ROI control Sergey Senozhatsky
2021-05-26 10:38 ` [PATCHv5 0/5] media: uvcvideo: implement UVC 1.5 ROI Hans Verkuil
2021-06-01 8:46 ` Sergey Senozhatsky [this message]
2021-06-01 8:52 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLXz+r8PkKx1VMVc@google.com \
--to=senozhatsky@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox