From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47360C47093 for ; Wed, 2 Jun 2021 16:44:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FF9B61A11 for ; Wed, 2 Jun 2021 16:44:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230081AbhFBQql (ORCPT ); Wed, 2 Jun 2021 12:46:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbhFBQqk (ORCPT ); Wed, 2 Jun 2021 12:46:40 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 943CDC06174A for ; Wed, 2 Jun 2021 09:44:41 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id l1so2733835pgm.1 for ; Wed, 02 Jun 2021 09:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v1f6CY6XzYIBDy4/kZuiiMp2Rh7Gg1cKpg7RU77/HAg=; b=Plf/wGF5S49Noco4Lig+ZtpLaf/nj2FWSq4m/6+/1iRatd/EzSpCq3HI3yM/phuTDg yLlOMxzhO3nO4qurZzgww8yeslx0ID5Oft7SF536Et0+q9iaUveoiSGuGprHU2r5aU9N tDK89CSSG06nSXiuhleCfCjYeyYcrSXSCVubM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v1f6CY6XzYIBDy4/kZuiiMp2Rh7Gg1cKpg7RU77/HAg=; b=SyNy6n24beg+IRQ1WEq8p+12ekN/hNXbJ3VtwJq9JrPDQ8aifcOftkGjYkxx/EnMl1 PEmREjHFq/fU4tHp2D8iTxO+KeqONJJhaj9iopNjCGtVZeuzmhzaelNoqbMPDgqySn1g BA3nmtvnemNlRL1KyhRw0Xfj5PfVZKBsgthQ819dF8waA1cK3/cf25WoOHR5g6S4UAxS phJ0NihcpDWYZGFDmUzA4YgnXgTEr/jyIvtsgiHmc6r2Agz8qtG5B3A8DtN6KtqoeJQh VuteZsqG1jIkmu4m4CJPXj7E/icuOi0X/bfcVa8y9jnPshZ7NBHHyL6IOyqiJic6zyYg QoKA== X-Gm-Message-State: AOAM530BlMIsWeP/GpMKqIlhdQGeVcB20NK/ozMxFovwB4vZXPx6EEq9 NOoeBw8ZgNQgysfWv5jjJ3pNkg== X-Google-Smtp-Source: ABdhPJyXVRE3MD31LcQEETFgTuL3GaZyuB8KTIU0GRkdXTHFP3v/4uWJaCnCXuP/7U112M4am8+zlA== X-Received: by 2002:aa7:8b44:0:b029:2dd:4cfc:7666 with SMTP id i4-20020aa78b440000b02902dd4cfc7666mr28339371pfd.73.1622652281039; Wed, 02 Jun 2021 09:44:41 -0700 (PDT) Received: from localhost ([2620:15c:202:201:d737:2805:1403:7c09]) by smtp.gmail.com with UTF8SMTPSA id z7sm275711pgr.28.2021.06.02.09.44.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 09:44:40 -0700 (PDT) Date: Wed, 2 Jun 2021 09:44:38 -0700 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Rob Herring , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Stephen Boyd , linux-arm-msm Subject: Re: [PATCH] arm64: dts: qcom: pm6150: Add thermal zone for PMIC on-die temperature Message-ID: References: <20210602090525.1.Id4510e9e4baaa3f6c9fdd5cdf4d8606e63c262e3@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, On Wed, Jun 02, 2021 at 09:36:07AM -0700, Doug Anderson wrote: > Hi, > > On Wed, Jun 2, 2021 at 9:06 AM Matthias Kaehlcke wrote: > > > > Add a thermal zone for the pm6150 on-die temperature. The system should > > try to shut down orderly when the temperature reaches 95degC, otherwise > > the PMIC will power off at 115degC. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > arch/arm64/boot/dts/qcom/pm6150.dtsi | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/pm6150.dtsi b/arch/arm64/boot/dts/qcom/pm6150.dtsi > > index 8ab4f1f78bbf..de7fb129f739 100644 > > --- a/arch/arm64/boot/dts/qcom/pm6150.dtsi > > +++ b/arch/arm64/boot/dts/qcom/pm6150.dtsi > > @@ -7,6 +7,30 @@ > > #include > > #include > > > > +/ { > > + thermal-zones { > > + pm6150_thermal: pm6150-thermal { > > + polling-delay-passive = <100>; > > + polling-delay = <0>; > > + thermal-sensors = <&pm6150_temp>; > > + > > + trips { > > + pm6150_trip0: trip0 { > > + temperature = <95000>; > > + hysteresis = <0>; > > + type = "passive"; > > + }; > > + > > + pm6150_crit: pm6150-crit { > > Nit that the node names are not symmetric. One is "trip0" and the > other is "pm6510-crit". Seems like you can remove the "pm6150-" prefix > from this one (but keep it in the label?) Sounds good. > > + temperature = <115000>; > > + hysteresis = <0>; > > + type = "critical"; > > + }; > > + }; > > + }; > > Correct me if I'm misunderstanding, but I don't think that the > description of this patch matches the contents. You're saying that the > PMIC will power itself off at 115C and that we want to do an orderly > shutdown _before_ the PMIC powers off. Doesn't that mean that the > "critical" trip needs to be at some temperature _lower_ than 115C? As > I remember it the system performs an orderly shutdown starting when it > sees the critical temperature. Yeah, you are right. Polling starts at 95degC, the system should try to shutdown at 115degC and based on that configuration the emergency shutdown would happen at 145degC: static const long temp_map_gen2_v1[THRESH_COUNT][STAGE_COUNT] = { { 90000, 110000, 140000 }, { 95000, 115000, 145000 }, { 100000, 120000, 150000 }, { 105000, 125000, 155000 }, }; I'll fix the commit message in the v2.