From: Ingo Molnar <mingo@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kbuild: Ctrl-C of parallel kernel build sometimes corrupts .o.cmd files permanently
Date: Thu, 3 Jun 2021 14:39:07 +0200 [thread overview]
Message-ID: <YLjNa7vaYOfVhBFm@gmail.com> (raw)
In-Reply-To: <CAK7LNAR54mOqEcUTUmEUfVAwA6XrGLr2J_3+v6fdys9tBLe28w@mail.gmail.com>
* Masahiro Yamada <masahiroy@kernel.org> wrote:
> Hmm, I have not observed this.
>
> My expectation is, it should work like this:
>
> When scripts/basic/fixdep is interrupted (or fail due to any reason),
> partially written *.o.cmd is left over. So, having incomplete *.o.cmd
> files is expectation.
>
> When .DELETE_ON_ERROR is specified, GNU Make is supposed to
> automatically delete the target on any error.
> (If it is interrupted, it should exit with code 130)
>
> On the next invocation of Make, Kbuild will not include .*.o.cmd files
> whose corresponding *.o files do not exist.
>
>
>
>
>
> When you got the corrupted drivers/gpu/drm/.drm_blend.o.cmd,
> didn't you see the log
> Deleting file 'drivers/gpu/drm/drm_blend.o' ?
>
>
>
> If it works as I expect, the log should look like follows:
> (I marked the lines with '<---- Deleting')
>
>
>
> CC security/keys/keyctl_pkey.o
> CC kernel/sys.o
> CC arch/x86/power/hibernate_64.o
> ^Cmake[5]: *** Deleting file 'drivers/video/fbdev/core/fbcmap.o' <---- Deleting
> make[5]: *** [scripts/Makefile.build:272:
> drivers/video/fbdev/core/fbmon.o] Interrupt
> make[3]: *** [scripts/Makefile.build:272: security/selinux/nlmsgtab.o] Interrupt
> make[2]: *** [scripts/Makefile.build:272: arch/x86/power/cpu.o] Interrupt
> make[2]: *** [scripts/Makefile.build:272:
Interestingly I don't get *any* interruption messages at all:
CC drivers/dma/dw/acpi.o
CC sound/pci/ice1712/ice1712.o
CC drivers/char/ipmi/ipmi_watchdog.o
CC fs/overlayfs/export.o
CC fs/nls/nls_cp936.o
CC drivers/char/ipmi/ipmi_poweroff.o
^Ckepler:~/tip>
The '^C' there - it just stops, make never prints anything for me.
Weird ...
Thanks,
Ingo
next prev parent reply other threads:[~2021-06-03 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 15:50 kbuild: Ctrl-C of parallel kernel build sometimes corrupts .o.cmd files permanently Ingo Molnar
2021-06-02 18:20 ` Masahiro Yamada
2021-06-03 12:39 ` Ingo Molnar [this message]
2021-06-03 12:43 ` Ingo Molnar
2021-06-04 3:22 ` Masahiro Yamada
2021-06-09 13:59 ` Masahiro Yamada
2021-06-12 13:25 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLjNa7vaYOfVhBFm@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox