From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BDEC47098 for ; Thu, 3 Jun 2021 19:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89B54613F4 for ; Thu, 3 Jun 2021 19:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbhFCTWQ (ORCPT ); Thu, 3 Jun 2021 15:22:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:60912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFCTWO (ORCPT ); Thu, 3 Jun 2021 15:22:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A7B2E613E4; Thu, 3 Jun 2021 19:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622748029; bh=yViDPULjzd1GROS9kt+NbcpBZPAN/s2nBt8ZDRoOfKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J0Huz00hKusFjvT9o349sTs31CLOqXbI0iBXLR2l2rDbYwLQGMSye6k0CN3fo4uoo 6PbD36MuOP04epUbr4YcjCt4oWcJu6a1yd+w4kC/mFDHWNCA6jB+mlclDZkB9qCPBz dCGJEXDPZQGbyrkicEI1IAM/uP32NNXqAxqpmy9K1cbvnn1LMQ0H8s92zCGawTu5+Y M1QIWYn4299MvQczpqYI8DVbCTWUKKlgMxDWpNArKe9pHYNV6u+DhBuCuUoTGA2949 6bmpQm0aFebKrasVxz488zaHwTlROSnueQIhxLmf1xkuglOH7TnrafCJj+C+nMCydM 7rdfb5TS8JumA== Date: Thu, 3 Jun 2021 12:20:28 -0700 From: Jaegeuk Kim To: Greg KH Cc: Daniel Rosenberg , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Message-ID: References: <20210603095038.314949-1-drosen@google.com> <20210603095038.314949-3-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03, Greg KH wrote: > On Thu, Jun 03, 2021 at 10:53:26AM -0700, Jaegeuk Kim wrote: > > On 06/03, Greg KH wrote: > > > On Thu, Jun 03, 2021 at 08:40:24AM -0700, Jaegeuk Kim wrote: > > > > On 06/03, Greg KH wrote: > > > > > On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: > > > > > > Older kernels don't support encryption with casefolding. This adds > > > > > > the sysfs entry encrypted_casefold to show support for those combined > > > > > > features. Support for this feature was originally added by > > > > > > commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > > > > > > > > > Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > > > Cc: stable@vger.kernel.org # v5.11+ > > > > > > Signed-off-by: Daniel Rosenberg > > > > > > --- > > > > > > fs/f2fs/sysfs.c | 15 +++++++++++++-- > > > > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > > > > > index 09e3f258eb52..6604291a3cdf 100644 > > > > > > --- a/fs/f2fs/sysfs.c > > > > > > +++ b/fs/f2fs/sysfs.c > > > > > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > > > > > if (f2fs_sb_has_compression(sbi)) > > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > > len ? ", " : "", "compression"); > > > > > > + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) > > > > > > + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > > + len ? ", " : "", "encrypted_casefold"); > > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > > len ? ", " : "", "pin_file"); > > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); > > > > > > > > > > This is a HUGE abuse of sysfs and should not be encouraged and added to. > > > > > > > > This feature entry was originally added in 2017. Let me try to clean this up > > > > after merging this. > > > > > > Thank you. > > > > > > > > Please make these "one value per file" and do not keep growing a single > > > > > file that has to be parsed otherwise you will break userspace tools. > > > > > > > > > > And I don't see a Documentation/ABI/ entry for this either :( > > > > > > > > There is in Documentation/ABI/testing/sysfs-fs-f2fs. > > > > > > So this new item was documented in the file before the kernel change was > > > made? > > > > Do we need to describe all the strings in this entry? > > > > 203 What: /sys/fs/f2fs//features > > 204 Date: July 2017 > > 205 Contact: "Jaegeuk Kim" > > 206 Description: Shows all enabled features in current device. > > Of course! Especially as this is a total violation of normal sysfs > files, how else are you going to parse the thing? > > Why wouldn't you describe the contents? Because I was lazy. :P Daniel, let me clean up all together in another patch. :) > > But again, please obsolete this file and make the features all > individual > files like they should be so that you do not have any parsing problems. Yup, will do. > > thanks, > > greg k-h