From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB3DC07E94 for ; Fri, 4 Jun 2021 09:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 360016140F for ; Fri, 4 Jun 2021 09:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbhFDJSC (ORCPT ); Fri, 4 Jun 2021 05:18:02 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:53059 "EHLO mail-wm1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbhFDJSC (ORCPT ); Fri, 4 Jun 2021 05:18:02 -0400 Received: by mail-wm1-f50.google.com with SMTP id f17so4944914wmf.2 for ; Fri, 04 Jun 2021 02:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=0iAE1eXsi7Ags0kCh2NQ+Xw4BO7hibZ8156NIUiiC9Y=; b=jXU7UgrylnRUSGeCbfj1NxKE31gatksb608K/jN+nlg9LYwbeaeTZoAwcju45NWPNL Dll+M8tntKovKq1yobA2cANrzCfOGfHj9DvwCTVs43XpI723jBuZkYsrqBolUZlPSvA4 1LH0u8TTFb6ZSwQUY/IReeDHz11/L/zgeWokY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=0iAE1eXsi7Ags0kCh2NQ+Xw4BO7hibZ8156NIUiiC9Y=; b=rv0ZDPQQ2HoLFKuzcwGvXY1J3DIkuav3UzyubW6807c3dD2LacB7fLJ+7X2vqdmPKu 2HKjYkxt0o5/CqCURBMjXQEIwVo/O7nJNSjd6BCxZDqJcdktgQph1bl22wMSOq+odxgX Rtp50ANQVAxFLc86tVFew1OOjYJPu2cyvkfgqs8b/zhNGmw5Jam8vel5hQQ/Ers1tbt6 1eHDHApZxxhW9rTmq0EYw95nAmerobILtJFqhUZ3/vRgLFQYr4lKDgGW0vZwWioaP1Sa 69WqNV91ZgDmTRy3RJCJDSFjmIZAyOMBLBvOcg3lLbU/iNCfJ9BtBCmCYhCnC1JRpNmz todg== X-Gm-Message-State: AOAM532VnQ+tql2/uCE/wzm/5OxB3ao/g5c+Q6AXSXemnqiaqwu234s8 hIz/LlJtVL4gmf7dqf3kPQnJymUHL4d8DA== X-Google-Smtp-Source: ABdhPJyTtG/bEVOcLkvg2qjVHIyuSghlJN1mBim4VUqjG8axFLCZdSqoqLk9+jMvv7gN3CG7HSk3Bg== X-Received: by 2002:a7b:c450:: with SMTP id l16mr2640565wmi.117.1622798115481; Fri, 04 Jun 2021 02:15:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id o17sm5681880wrp.47.2021.06.04.02.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 02:15:15 -0700 (PDT) Date: Fri, 4 Jun 2021 11:15:13 +0200 From: Daniel Vetter To: Linus Walleij Cc: Kees Cook , Daniel Vetter , Emma Anholt , David Airlie , linux-kernel , "open list:DRM PANEL DRIVERS" Subject: Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends Message-ID: Mail-Followup-To: Linus Walleij , Kees Cook , Emma Anholt , David Airlie , linux-kernel , "open list:DRM PANEL DRIVERS" References: <20210604014055.4060521-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote: > On Fri, Jun 4, 2021 at 3:41 AM Kees Cook wrote: > > > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when > > pl111 is modular. Update the Kconfig to reflect the need. > > > > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG") > > Yeah that doesn't work, thanks for fixing this! > > > Signed-off-by: Kees Cook > > > - depends on VEXPRESS_CONFIG > > + depends on ARM || ARM64 || COMPILE_TEST > > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n > > That's the right solution, > Reviewed-by: Linus Walleij Since I screwed up already, care to also push this to drm-misc-next? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch