From: Greg KH <gregkh@linuxfoundation.org>
To: ricky_wu@realtek.com
Cc: arnd@arndb.de, bhelgaas@google.com, rui_feng@realsil.com.cn,
ulf.hansson@linaro.org, vaibhavgupta40@gmail.com,
yang.lee@linux.alibaba.com,
keitasuzuki.park@sslab.ics.keio.ac.jp, chris.chiu@canonical.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG
Date: Fri, 4 Jun 2021 16:48:27 +0200 [thread overview]
Message-ID: <YLo9O/gGOuFIsVH0@kroah.com> (raw)
In-Reply-To: <20210604144211.6470-1-ricky_wu@realtek.com>
On Fri, Jun 04, 2021 at 10:42:11PM +0800, ricky_wu@realtek.com wrote:
> From: Ricky Wu <ricky_wu@realtek.com>
>
> Divide Realtek Card Reader Group into two different modes
> ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250
> Change back to use original way to control aspm
What is "aspm"?
> +#define ASPM_MODE_CFG 0x01
> +#define ASPM_MODE_REG 0x02
> + u8 aspm_mode;
Why not use an enum?
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-04 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 14:42 [PATCH] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG ricky_wu
2021-06-04 14:48 ` Greg KH [this message]
2021-06-07 2:34 ` Ricky WU
2021-06-07 4:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLo9O/gGOuFIsVH0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=chris.chiu@canonical.com \
--cc=keitasuzuki.park@sslab.ics.keio.ac.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=rui_feng@realsil.com.cn \
--cc=ulf.hansson@linaro.org \
--cc=vaibhavgupta40@gmail.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox