From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DAFC4743C for ; Fri, 4 Jun 2021 23:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FAEB61369 for ; Fri, 4 Jun 2021 23:02:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231796AbhFDXEZ (ORCPT ); Fri, 4 Jun 2021 19:04:25 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46322 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbhFDXEW (ORCPT ); Fri, 4 Jun 2021 19:04:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=XnHNL9lXkaLbHEM9f6N6hjdSr6gfj4Pqg+S2saBsR9A=; b=I3N7/RclzjfqTaXqB+0wsQhxSX CI1GZtiPlJAkjBhoBeTlmWQQVBM3TdonWBHGE1ztKy3NgVJS/xKowfsYLgWEETUqM2/oY0GslNIYl hZMCt8bujzA0Thi8Sp2qhTQoC99R+PBs+3ycFwj/rZ/9ZfNYNKOsmNEXe3o89EaGk5lI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lpIpZ-007sCc-AA; Sat, 05 Jun 2021 01:02:21 +0200 Date: Sat, 5 Jun 2021 01:02:21 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: dingsenjie@163.com, richardcochran@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dingsenjie Subject: Re: [PATCH] net: phy: Simplify the return expression of dp83640_ack_interrupt Message-ID: References: <20210604032224.136268-1-dingsenjie@163.com> <91609670-c3a2-2281-514e-01dfe7907f11@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91609670-c3a2-2281-514e-01dfe7907f11@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 09:49:17AM +0200, Heiner Kallweit wrote: > On 04.06.2021 05:22, dingsenjie@163.com wrote: > > From: dingsenjie > > > > Simplify the return expression. > > > > Signed-off-by: dingsenjie > > --- > > drivers/net/phy/dp83640.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c > > index 0d79f68..bcd14ec 100644 > > --- a/drivers/net/phy/dp83640.c > > +++ b/drivers/net/phy/dp83640.c > > @@ -1141,12 +1141,7 @@ static int dp83640_config_init(struct phy_device *phydev) > > > > static int dp83640_ack_interrupt(struct phy_device *phydev) > > { > > - int err = phy_read(phydev, MII_DP83640_MISR); > > - > > - if (err < 0) > > - return err; > > - > > - return 0; > > + return phy_read(phydev, MII_DP83640_MISR); > > } > > > > static int dp83640_config_intr(struct phy_device *phydev) > > > This would be a functional change. You'd return a positive value > instead of 0. And looking a bit further down in the code: static int dp83640_ack_interrupt(struct phy_device *phydev) { int err = phy_read(phydev, MII_DP83640_MISR); if (err < 0) return err; return 0; } static int dp83640_config_intr(struct phy_device *phydev) { int micr; int misr; int err; if (phydev->interrupts == PHY_INTERRUPT_ENABLED) { err = dp83640_ack_interrupt(phydev); if (err) return err; So a positive value is going to break the driver. NACK Andrew