From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130FFC4743F for ; Sat, 5 Jun 2021 10:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB22E613D8 for ; Sat, 5 Jun 2021 10:49:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbhFEKvl (ORCPT ); Sat, 5 Jun 2021 06:51:41 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:36785 "EHLO mail-pl1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbhFEKvj (ORCPT ); Sat, 5 Jun 2021 06:51:39 -0400 Received: by mail-pl1-f173.google.com with SMTP id x10so5954625plg.3 for ; Sat, 05 Jun 2021 03:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=puvKdnbjMWRss9Xc+jeycrE74wvzwgdG7JS/tm3IR6Q=; b=VNMp6zMbH6Ai/UggoxUb8JogjuT4S/q2uuPY4DIP7HPKXrHzIX+KooI9HZ1UZn30yB H8WrYZ4q+lcp6WyeRq/rpgSCfcJ87MRwrTwNBg8KG1YkvIKF6Pbxi6QpOQ07BZ9r3c7M 5pM8UM2Uy6rb8+7j+Y4sKGgi6L1lhdvEuurmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=puvKdnbjMWRss9Xc+jeycrE74wvzwgdG7JS/tm3IR6Q=; b=WQvpCnoyf+Bwe0Ui7/SLC5xB+dGljtfuFg7UzFrTnfJbGdLQJP+r18LgylDNHz4HeM cAWFmrorx5eSRKTp7AHm4/XO5dbHLmD/cDFGrEnmXrAt9PQBBGLG87pdtXQNYY2H8NYX gO3tW1BknbBTShvZzrQLraq4V+QBviLr/Ogn7dx4/X83YptK3gZqUhqqxHKllFd9Ek8+ xxYWuyjltJ+hXxL5csNCcQpvXYz8SgzKCmZcYw8GwBxCc9EuGV6LoJHUVzpyMC2mRf/G SMRdeKTfLLHTXOagvTdCL6AJbubgrqsYweItgvg5cRJ0LsKav40ywTuyCdHPhe0eLmlu hL7w== X-Gm-Message-State: AOAM533g4I91n5BUkCUESafgfTBHj+QxlIu2mu7NhJxk8lIVZ47qd4GN hKVIgdpU2eNyppdoI8QbyVKQPw== X-Google-Smtp-Source: ABdhPJxQenHO0csxkientjHPUyIKwoWUMZs3GjdceB3pQigyjUSVLp9kfLlM4L4bqXVJH20LFqMqyQ== X-Received: by 2002:a17:902:e04e:b029:10f:133f:87c8 with SMTP id x14-20020a170902e04eb029010f133f87c8mr8260590plx.70.1622890131931; Sat, 05 Jun 2021 03:48:51 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:5981:261e:350c:bb45]) by smtp.gmail.com with ESMTPSA id j12sm3921984pgj.14.2021.06.05.03.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 03:48:51 -0700 (PDT) Date: Sat, 5 Jun 2021 19:48:46 +0900 From: Sergey Senozhatsky To: Marc Zyngier Cc: Sergey Senozhatsky , Paolo Bonzini , Vitaly Kuznetsov , Peter Zijlstra , Suleiman Souhlal , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/2] kvm: x86: implement KVM PM-notifier Message-ID: References: <20210605023042.543341-1-senozhatsky@chromium.org> <20210605023042.543341-2-senozhatsky@chromium.org> <87k0n8u1nk.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k0n8u1nk.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/06/05 10:00), Marc Zyngier wrote: > > +static int kvm_arch_suspend_notifier(struct kvm *kvm) > > +{ > > + struct kvm_vcpu *vcpu; > > + int i, ret; > > + > > + mutex_lock(&kvm->lock); > > + kvm_for_each_vcpu(i, vcpu, kvm) { > > + ret = kvm_set_guest_paused(vcpu); > > + if (ret) { > > + pr_err("Failed to pause guest VCPU%d: %d\n", > > + vcpu->vcpu_id, ret); > > how useful the pr_err() is, given that it contains no information > that would help identifying which guest failed to pause. Do other printk-s contain such info? All I can see so far is `#define pr_fmt(fmt) "kvm-guest: " fmt` which doesn't point at any particular VM.