From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: bleung@chromium.org, enric.balletbo@collabora.com,
groeck@chromium.org, philipchen@chromium.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] Input: cros_ec_keyb - Fix kobj_to_dev.cocci warnings
Date: Sat, 19 Jun 2021 22:25:06 -0700 [thread overview]
Message-ID: <YM7RMvCuHPfLkjVX@google.com> (raw)
In-Reply-To: <20210607122616.1316-1-yuehaibing@huawei.com>
On Mon, Jun 07, 2021 at 08:26:16PM +0800, YueHaibing wrote:
> Use kobj_to_dev() instead of container_of()
>
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Ended up picking another incarnation of this same patch, sorry.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/input/keyboard/cros_ec_keyb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 38457d9641bd..fc02c540636e 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -644,7 +644,7 @@ static umode_t cros_ec_keyb_attr_is_visible(struct kobject *kobj,
> struct attribute *attr,
> int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct cros_ec_keyb *ckdev = dev_get_drvdata(dev);
>
> if (attr == &dev_attr_function_row_physmap.attr &&
> --
> 2.17.1
>
--
Dmitry
prev parent reply other threads:[~2021-06-20 5:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 12:26 [PATCH -next] Input: cros_ec_keyb - Fix kobj_to_dev.cocci warnings YueHaibing
2021-06-20 5:25 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YM7RMvCuHPfLkjVX@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipchen@chromium.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox