From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v1 1/1] usb: typec: wcove: Use LE to CPU conversion when accessing msg->header
Date: Wed, 9 Jun 2021 10:56:42 +0200 [thread overview]
Message-ID: <YMCCSiNnvc9oh7P+@kroah.com> (raw)
In-Reply-To: <YL47Ny7hXZmgH/dx@smile.fi.intel.com>
On Mon, Jun 07, 2021 at 06:28:55PM +0300, Andy Shevchenko wrote:
> On Thu, May 20, 2021 at 12:26:25PM +0300, Heikki Krogerus wrote:
> > On Wed, May 19, 2021 at 11:55:34AM +0300, Andy Shevchenko wrote:
> > > As LKP noticed the Sparse is not happy about strict type handling:
> > > .../typec/tcpm/wcove.c:380:50: sparse: expected unsigned short [usertype] header
> > > .../typec/tcpm/wcove.c:380:50: sparse: got restricted __le16 const [usertype] header
> > >
> > > Fix this by switching to use pd_header_cnt_le() instead of pd_header_cnt()
> > > in the affected code.
> > >
> > > Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> Thanks!
>
> Greg, should I amend or resend this?
Both please.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-09 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 8:55 [PATCH v1 1/1] usb: typec: wcove: Use LE to CPU conversion when accessing msg->header Andy Shevchenko
2021-05-20 9:26 ` Heikki Krogerus
2021-06-07 15:28 ` Andy Shevchenko
2021-06-09 8:56 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-19 10:02 Andy Shevchenko
2021-05-19 12:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMCCSiNnvc9oh7P+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox