From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B314CC48BCD for ; Thu, 10 Jun 2021 04:06:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 921E660232 for ; Thu, 10 Jun 2021 04:06:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbhFJEIC (ORCPT ); Thu, 10 Jun 2021 00:08:02 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55578 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbhFJEIB (ORCPT ); Thu, 10 Jun 2021 00:08:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=KjuI8jCqUcyAfx/5RiZL0Drr0Q511dbsI0/UHVUJCP8=; b=rO4X1G0tCX5Sohmhmo7qnuwcHQ IQbYkL+40DJiuLX/GRDJgHGB48j2wcUgEdNXw/d/YSzTMVWHKJEn8F7VKZfBMZswvdUAhvvZU/Suj EsqUsc3DlYkO/NY03/M4krmZ5RK9hv0cskiEZU7pwSzFJpRpzVrjmztGVXwz03dgsvjI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lrBx6-008bPL-He; Thu, 10 Jun 2021 06:05:56 +0200 Date: Thu, 10 Jun 2021 06:05:56 +0200 From: Andrew Lunn To: Wong Vee Khee Cc: Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/1] net: phy: probe for C45 PHYs that return PHY ID of zero in C22 space Message-ID: References: <20210607023645.2958840-1-vee.khee.wong@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607023645.2958840-1-vee.khee.wong@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 07, 2021 at 10:36:45AM +0800, Wong Vee Khee wrote: > PHY devices such as the Marvell Alaska 88E2110 does not return a valid > PHY ID when probed using Clause-22. The current implementation treats > PHY ID of zero as a non-error and valid PHY ID, and causing the PHY > device failed to bind to the Marvell driver. > > For such devices, we do an additional probe in the Clause-45 space, > if a valid PHY ID is returned, we then proceed to attach the PHY > device to the matching PHY ID driver. > > Signed-off-by: Wong Vee Khee Reviewed-by: Andrew Lunn Andrew