From: Borislav Petkov <bp@alien8.de>
To: Baokun Li <libaokun1@huawei.com>
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
hpa@zytor.com, jroedel@suse.de, trix@redhat.com,
brijesh.singh@amd.com, rostedt@goodmis.org,
ying-tsun.huang@amd.com, linux-kernel@vger.kernel.org,
weiyongjun1@huawei.com, yuehaibing@huawei.com,
yangjihong1@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH -next] x86/mm/mtrr: fix doc warnings in generic.c
Date: Thu, 10 Jun 2021 09:35:48 +0200 [thread overview]
Message-ID: <YMHA1IFHVPHfNC2D@zn.tnic> (raw)
In-Reply-To: <20210605064821.694432-1-libaokun1@huawei.com>
On Sat, Jun 05, 2021 at 02:48:21PM +0800, Baokun Li wrote:
> @@ -104,7 +104,8 @@ static int check_type_overlap(u8 *prev, u8 *curr)
>
> /**
> * mtrr_type_lookup_fixed - look up memory type in MTRR fixed entries
> - *
> + * @start: Start addaress.
addaress?
Spellchecker?
> + * @end: End address.
> * Return the MTRR fixed memory type of 'start'.
> *
> * MTRR fixed entries are divided into the following ways:
> @@ -143,7 +144,11 @@ static u8 mtrr_type_lookup_fixed(u64 start, u64 end)
>
> /**
> * mtrr_type_lookup_variable - look up memory type in MTRR variable entries
> - *
> + * @start: Start addaress.
addaress?
Spellchecker?
> + * @end: End address.
> + * @partial_end: Partial end address.
> + * @repeat: Memory is repeat or not.
> + * @uniform: Memory is uniform or not.
Did you actually read that whole comment to see that maybe "repeat" and
"uniform" are explained a bit further down or are you blindly "fixing"
warnings just so that the tool shuts up?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-06-10 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 6:48 [PATCH -next] x86/mm/mtrr: fix doc warnings in generic.c Baokun Li
2021-06-10 7:35 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMHA1IFHVPHfNC2D@zn.tnic \
--to=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=trix@redhat.com \
--cc=weiyongjun1@huawei.com \
--cc=x86@kernel.org \
--cc=yangjihong1@huawei.com \
--cc=ying-tsun.huang@amd.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox