Re: [PATCH] pinctrl: intel: fix NULL pointer deref

Andy Shevchenko
2021-06-09T10:34:54Z

On Wed, Jun 9, 2021 at 1:12 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Wed, Jun 09, 2021 at 08:27:22AM +0200, Henning Schild wrote:
> > match could be NULL in which case we do not go ACPI after all

...

> > adev = ACPI_COMPANION(&pdev->dev);
> > - if (adev) {
> > - const void *match = device_get_match_data(&pdev->dev);
> > -
> > + match = device_get_match_data(&pdev->dev);
>
> Actually we don't even call intel_pinctrl_get_soc_data() if the ACPI ID
> is not listed in the corresponding driver's module table. So I don't
> think match can ever be NULL.
>
> But feel free to prove me wrong ;-)

It's possible to have bugs in this driver, but can we see the real case here?