From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2] perf evsel: Adjust hybrid event and global event mixed group
Date: Thu, 10 Jun 2021 13:43:11 -0300 [thread overview]
Message-ID: <YMJBH6Os6IgE9NYh@kernel.org> (raw)
In-Reply-To: <YMEhYYwQaT5i9/UE@krava>
Em Wed, Jun 09, 2021 at 10:15:29PM +0200, Jiri Olsa escreveu:
> On Wed, Jun 09, 2021 at 12:45:55PM +0800, Jin Yao wrote:
> > A group mixed with hybrid event and global event is allowed. For example,
> > group leader is 'intel_pt//' and the group member is 'cpu_atom/cycles/'.
> >
> > e.g.
> > perf record --aux-sample -e '{intel_pt//,cpu_atom/cycles/}:u'
> >
> > The challenge is their available cpus are not fully matched. For example,
> > 'intel_pt//' is available on CPU0-CPU23, but 'cpu_atom/cycles/' is
> > available on CPU16-CPU23.
> >
> > When getting the group id for group member, we must be very careful.
> > Because the cpu for 'intel_pt//' is not equal to the cpu for
> > 'cpu_atom/cycles/'. Actually the cpu here is the index of evsel->core.cpus,
> > not the real CPU ID.
<SNIP>
> > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> looks good to me
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2021-06-10 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 4:45 [PATCH v2] perf evsel: Adjust hybrid event and global event mixed group Jin Yao
2021-06-09 20:15 ` Jiri Olsa
2021-06-10 16:43 ` Arnaldo Carvalho de Melo [this message]
2021-12-08 6:50 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMJBH6Os6IgE9NYh@kernel.org \
--to=acme@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox