Re: [PATCH RESEND v2 4/5] extcon: extcon-max8997: Fix IRQ freeing at error path

Chanwoo Choi
2021-06-10T09:34:39Z

On 6/8/21 7:10 PM, Matti Vaittinen wrote:
> If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits
> without freeing the requested IRQs.
>
> Free the IRQs prior returning if reading the status fails.
>
> Fixes: 3e34c8198960 ("extcon: max8997: Avoid forcing UART path on drive probe")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changelog:
> v2:
> - new patch (avoid backporting devm_wq just to fix IRQ freeing)
> ---
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index e1408075ef7d..c15a612067af 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -733,7 +733,7 @@ static int max8997_muic_probe(struct platform_device *pdev)
> 2, info->status);
> if (ret) {
> dev_err(info->dev, "failed to read MUIC register\n");
> - return ret;
> + goto err_irq;
> }
> cable_type = max8997_muic_get_cable_type(info,
> MAX8997_CABLE_GROUP_ADC, &attached);
>

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

--
Best Regards,
Chanwoo Choi
Samsung Electronics