From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7230C48BDF for ; Thu, 10 Jun 2021 23:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B887E613F1 for ; Thu, 10 Jun 2021 23:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbhFJXCp (ORCPT ); Thu, 10 Jun 2021 19:02:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:44864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbhFJXCo (ORCPT ); Thu, 10 Jun 2021 19:02:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE0B6613E1; Thu, 10 Jun 2021 23:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623366048; bh=0JBPBRnwjMclTlgWuSDhjEf5Q89skZtWG7GkA9KzUOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uHhjoSA6nP+kIztHgQ3HQ3dqO2ILsNgGtSmfMfWa8LqBII1Yyi6bpJCk2j/3vW+oM gtby8hX3ZLdoMas+nsTkjijhVAE1bhSbmSw+9Uvg9FP6kYpdDUWVZiSUHtNIXXZGEy at+JNLk6zJ0xOkDXOMvPsxr/RLktx/x39B9hwQqa62eeLuYU3FVziva7ES2r7c1NWB Re6/RlgYNkeKM+2QOQ8T+AYYtNd1gVLVrBzxsBhW+13bQcJ/baJt4KjAnVRUFugpUR D5zbzxtT6kP3AclSnancb03DrLOpdRbG5YTdu1DohP9xxbHZ50ybS0wu4ulEJGXGFx 65GO2Yu23EW6Q== Date: Thu, 10 Jun 2021 16:00:46 -0700 From: Eric Biggers To: Liu Shixin Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] crypto: remove CRYPTOA_U32 and related functions Message-ID: References: <20210605053902.2017295-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210605053902.2017295-1-liushixin2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 05, 2021 at 01:39:02PM +0800, Liu Shixin wrote: > According to the advice of Eric and Herbert, type CRYPTOA_U32 > has been unused for over a decade, so remove the code related to > CRYPTOA_U32. > > After removing CRYPTOA_U32, the type of the variable attrs can be > changed from union to struct. > > Signed-off-by: Liu Shixin > --- > crypto/algapi.c | 18 ------------------ > crypto/algboss.c | 32 +++++++------------------------- > include/crypto/algapi.h | 1 - > include/linux/crypto.h | 5 ----- > 4 files changed, 7 insertions(+), 49 deletions(-) Reviewed-by: Eric Biggers One nit below: > + param->attrs[i].attr.rta_len = > + sizeof(param->attrs[i]); These two lines can be joined into one. - Eric