From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3CE8C48BDF for ; Thu, 10 Jun 2021 23:09:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C949861002 for ; Thu, 10 Jun 2021 23:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbhFJXLQ (ORCPT ); Thu, 10 Jun 2021 19:11:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:47954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhFJXLP (ORCPT ); Thu, 10 Jun 2021 19:11:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B1FAA613D9; Thu, 10 Jun 2021 23:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623366558; bh=sehk7qVLTT99iBgWRG6d/XNEMQO3VwZUaO5rBbGONUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NF4EHiwQE/k2Ptgw6ReqIxI3Y7d3D6jDUeucaY9ot/SZGYXs2GfKym469zY9y+VII CMrHBZTY8Hp6MOU9wG7EsYmdBBd3RL2za0ykca8OhXMrgKm3ji2Chc5z8RvaoI1mEB TRyd1CupfTyQAlrdCkwsAGDH0dzSsX6YuaAHApth/Hf4dvY2UD7RbpLO0C40u4JPAg CIeZ76IJ85ZmCdEvWkXYtT3nDko4D+9CiBsUh9mcOmgg3eFkMT20OS/81Lh9cJkx/I FdULipM3yAfUWjl76a3h/hl6OkQxGMAMIQ6NnMLNXoNPwe0MeP3tdZLldV160zWbK5 ywbbfKlQsQx8Q== Date: Thu, 10 Jun 2021 16:09:17 -0700 From: Eric Biggers To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/3 v2] f2fs: clean up /sys/fs/f2fs//features Message-ID: References: <20210605003210.856458-1-jaegeuk@kernel.org> <20210605003210.856458-3-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 05, 2021 at 10:36:10PM -0700, Jaegeuk Kim wrote: > Let's create /sys/fs/f2fs//feature_list/ to meet sysfs rule. > > Note that there are three feature list entries: > 1) /sys/fs/f2fs/features > : shows runtime features supported by in-kernel f2fs along with Kconfig. > - ref. F2FS_FEATURE_RO_ATTR() > > 2) /sys/fs/f2fs/$s_id/features > : shows on-disk features enabled by mkfs.f2fs, used for old kernels. This > won't add new feature anymore, and thus, users should check entries in 3) > instead of this 2). > > 3) /sys/fs/f2fs/$s_id/feature_list > : shows on-disk features enabled by mkfs.f2fs per instance, which follows > sysfs entry rule where each entry should expose single value. > This list covers old feature list provided by 2) and beyond. Therefore, > please add new on-disk feature in this list only. > - ref. F2FS_SB_FEATURE_RO_ATTR() > > Signed-off-by: Jaegeuk Kim > --- > > change log from v1: > - adjust Eric's comment > > Documentation/ABI/testing/sysfs-fs-f2fs | 29 +++- > fs/f2fs/f2fs.h | 3 + > fs/f2fs/sysfs.c | 196 ++++++++++++++++-------- > 3 files changed, 163 insertions(+), 65 deletions(-) Reviewed-by: Eric Biggers - Eric