From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 738A5C48BD1 for ; Fri, 11 Jun 2021 08:55:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57D33613C3 for ; Fri, 11 Jun 2021 08:55:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbhFKI52 (ORCPT ); Fri, 11 Jun 2021 04:57:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:59342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231191AbhFKI5X (ORCPT ); Fri, 11 Jun 2021 04:57:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 86BC5613C3; Fri, 11 Jun 2021 08:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623401712; bh=7y3c2umdmrm7dYoTAKQg9HHAvb1xKES58xh/t9aHSFc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XLjd4LMalfNs+xA//zu0vrIAATcqKlsu4FqXkzmLeu4Ll7fGFkMDIlvuutcG0CKti 2w/nMLqlrL2afhv4ZSyD+xuu/onxDS44f7yghOkE7fA/RUcgDQyUIKcjPUvf8NeFBj ck2l3wjftJhFpmYNfYgIg4Kfqkq6ZsQrPr4McJes= Date: Fri, 11 Jun 2021 10:55:09 +0200 From: Greg KH To: Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org, Bixuan Cui , Hulk Robot Subject: Re: [PATCH 1/9] nvmem: sprd: Add missing MODULE_DEVICE_TABLE Message-ID: References: <20210611083348.20170-1-srinivas.kandagatla@linaro.org> <20210611083348.20170-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611083348.20170-2-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 11, 2021 at 09:33:40AM +0100, Srinivas Kandagatla wrote: > From: Bixuan Cui > > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support") > Reported-by: Hulk Robot > Signed-off-by: Bixuan Cui > Signed-off-by: Srinivas Kandagatla > --- > drivers/nvmem/sprd-efuse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c > index 59523245db8a..5d394559edf2 100644 > --- a/drivers/nvmem/sprd-efuse.c > +++ b/drivers/nvmem/sprd-efuse.c > @@ -425,6 +425,7 @@ static const struct of_device_id sprd_efuse_of_match[] = { > { .compatible = "sprd,ums312-efuse", .data = &ums312_data }, > { } > }; > +MODULE_DEVICE_TABLE(of, sprd_efuse_of_match); Why is this needed? Do you have reports of this module not being properly auto-loaded? I have been rejecting these types of patches from the "Hulk Robot" as they were just blindly going through the tree and not determining if this actually is a thing that needed to be fixed. Also, if it is a real fix, shouldn't it also go to the stable kernel trees? If so, you didn't mark it as such :( thanks, greg k-h