From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073ECC48BD1 for ; Fri, 11 Jun 2021 09:45:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E603F613D0 for ; Fri, 11 Jun 2021 09:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbhFKJr0 (ORCPT ); Fri, 11 Jun 2021 05:47:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:43336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230212AbhFKJrZ (ORCPT ); Fri, 11 Jun 2021 05:47:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 45A46613D3; Fri, 11 Jun 2021 09:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623404727; bh=+58FlxSrjNojUJXBKRVBDazHQJJ8tkA6vWSAkIwcd+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hLyYOTOheO5lf8OtiFV90jO3wpeQEvpDE3vuvR0va6d/LKx0chFa1dGfXqPLfq2Js Lh6vck+iN21vMAmPNL0fvNtrwzTHj+mMt1BQTQ2kO34Yus2t1jFtDhkqfyTFlhrFEj eHYzTpP+bq64eulPursb3H500xmujvoDZ+o12Dz8= Date: Fri, 11 Jun 2021 11:45:25 +0200 From: Greg KH To: Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org, Christophe JAILLET , Chunyan Zhang Subject: Re: [PATCH 4/9] nvmem: sprd: Fix an error message Message-ID: References: <20210611083348.20170-1-srinivas.kandagatla@linaro.org> <20210611083348.20170-5-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 11, 2021 at 11:17:50AM +0200, Greg KH wrote: > On Fri, Jun 11, 2021 at 10:05:40AM +0100, Srinivas Kandagatla wrote: > > > > > > On 11/06/2021 09:56, Greg KH wrote: > > > On Fri, Jun 11, 2021 at 09:33:43AM +0100, Srinivas Kandagatla wrote: > > > > From: Christophe JAILLET > > > > > > > > 'ret' is known to be 0 here. > > > > The expected error status is stored in 'status', so use it instead. > > > > > > > > Also change %d in %u, because status is an u32, not a int. > > > > > > > > Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support") > > > > Signed-off-by: Christophe JAILLET > > > > Acked-by: Chunyan Zhang > > > > Signed-off-by: Srinivas Kandagatla > > > > --- > > > > drivers/nvmem/sprd-efuse.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c > > > > index 5d394559edf2..e3e721d4c205 100644 > > > > --- a/drivers/nvmem/sprd-efuse.c > > > > +++ b/drivers/nvmem/sprd-efuse.c > > > > @@ -234,7 +234,7 @@ static int sprd_efuse_raw_prog(struct sprd_efuse *efuse, u32 blk, bool doub, > > > > status = readl(efuse->base + SPRD_EFUSE_ERR_FLAG); > > > > if (status) { > > > > dev_err(efuse->dev, > > > > - "write error status %d of block %d\n", ret, blk); > > > > + "write error status %u of block %d\n", status, blk); > > > > > > Shouldn't this be %pe and not %u? > > > > This is not error pointer its status value read back from a register. > > > > I think %u should be good here. > > Argh, you are right, my fault. For some reason I thought this worked > for integers as well. Don't we have such a printk modifier somewhere to > turn error values into strings? Let me dig... Ah, errname() will do it. Looks like no one uses it, so nevermind, sorry for the noise. I'll go apply this one now. thanks, greg k-h