Re: [PATCH 4/4] driver core: Allow showing cpu as offline if not valid in cpuset context

Greg KH
2021-06-14T15:52:38Z

On Mon, Jun 14, 2021 at 11:23:06AM -0400, Waiman Long wrote:
> Make /sys/devices/system/cpu/cpu<n>/online file to show a cpu as
> offline if it is not a valid cpu in a proper cpuset context when the
> cpuset_bound_cpuinfo sysctl parameter is turned on.

This says _what_ you are doing, but I do not understand _why_ you want
to do this.

What is going to use this information? And now you are showing more
files than you previously did, so what userspace tool is now going to
break?

>
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
> drivers/base/core.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 54ba506e5a89..176b927fade2 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -29,6 +29,7 @@
> #include <linux/sched/mm.h>
> #include <linux/sysfs.h>
> #include <linux/dma-map-ops.h> /* for dma_default_coherent */
> +#include <linux/cpuset.h>
>
> #include "base.h"
> #include "power/power.h"
> @@ -2378,11 +2379,24 @@ static ssize_t uevent_store(struct device *dev, struct device_attribute *attr,
> }
> static DEVICE_ATTR_RW(uevent);
>
> +static bool is_device_cpu(struct device *dev)
> +{
> + return dev->bus && dev->bus->dev_name
> + && !strcmp(dev->bus->dev_name, "cpu");
> +}

No, this is not ok, there is a reason we did not put RTTI in struct
devices, so don't try to fake one here please.

> +
> static ssize_t online_show(struct device *dev, struct device_attribute *attr,
> char *buf)
> {
> bool val;
>
> + /*
> + * Show a cpu as offline if the cpu number is not valid in a
> + * proper cpuset bounding cpuinfo context.
> + */
> + if (is_device_cpu(dev) && !cpuset_current_cpu_valid(dev->id))
> + return sysfs_emit(buf, "0\n");

Why are you changing the driver core for a single random, tiny set of
devices? The device code for those devices can handle this just fine,
do NOT modify the driver core for each individual driver type, that way
lies madness.

This change is not ok, sorry.

greg k-h