Re: [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card

sbhanu
2021-06-14T11:46:14Z

On 2021-06-10 13:24, Konrad Dybcio wrote:
> Hi,
>
>
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -701,8 +701,9 @@
>> interrupt-names = "hc_irq", "pwr_irq";
>>
>> clocks = <&gcc GCC_SDCC1_APPS_CLK>,
>> - <&gcc GCC_SDCC1_AHB_CLK>;
>> - clock-names = "core", "iface";
>> + <&gcc GCC_SDCC1_AHB_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>
> Don't these clocks fit in 100 chars?
These two clocks can fit in 100 chars but we have 3 clocks they don't
fit in 100 chars.
>
>
>
>> + clock-names = "core", "iface","xo";
>
> A space is missing before "xo".
Sure
>
>
>
>> interconnects = <&aggre1_noc MASTER_EMMC 0 &mc_virt SLAVE_EBI1 0>,
>> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_EMMC_CFG 0>;
>> interconnect-names = "sdhc-ddr","cpu-sdhc";
>> @@ -2666,8 +2667,9 @@
>> interrupt-names = "hc_irq", "pwr_irq";
>>
>> clocks = <&gcc GCC_SDCC2_APPS_CLK>,
>> - <&gcc GCC_SDCC2_AHB_CLK>;
>> - clock-names = "core", "iface";
>> + <&gcc GCC_SDCC2_AHB_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>
> Ditto
Same as above
>
>
>
> Konrad