Re: [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card

Konrad Dybcio
2021-06-14T11:50:13Z

On 14.06.2021 13:44, sbhanu@codeaurora.org wrote:
> On 2021-06-10 13:24, Konrad Dybcio wrote:
>> Hi,
>>
>>
>>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>> @@ -701,8 +701,9 @@
>>>              interrupt-names = "hc_irq", "pwr_irq";
>>>
>>>              clocks = <&gcc GCC_SDCC1_APPS_CLK>,
>>> -                    <&gcc GCC_SDCC1_AHB_CLK>;
>>> -            clock-names = "core", "iface";
>>> +                    <&gcc GCC_SDCC1_AHB_CLK>,
>>> +                    <&rpmhcc RPMH_CXO_CLK>;
>>
>> Don't these clocks fit in 100 chars?
> These two clocks can fit in 100 chars but we have 3 clocks they don't fit in 100 chars.

You're right.

With the space before xo,

Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad