From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Punit Agrawal <punitagrawal@gmail.com>
Cc: pmladek@suse.com, senozhatsky@chromium.org, rostedt@goodmis.org,
john.ogness@linutronix.de, linux@rasmusvillemoes.dk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition
Date: Wed, 16 Jun 2021 10:30:33 +0900 [thread overview]
Message-ID: <YMlUOdpMEnTd2RSs@google.com> (raw)
In-Reply-To: <20210614235635.887365-1-punitagrawal@gmail.com>
On (21/06/15 08:56), Punit Agrawal wrote:
> Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while
> improving readability by removing vprintk indirection, inadvertently
> placed the EXPORT_SYMBOL() for the newly renamed function at the end
> of the file.
>
> For reader sanity, and as is convention move the EXPORT_SYMBOL()
> declaration just after the end of the function.
>
> Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk")
> Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
Acked-by: Sergey Senozhatsky <senozhatsky@chromium.org>
prev parent reply other threads:[~2021-06-16 1:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 23:56 [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition Punit Agrawal
2021-06-15 6:50 ` Rasmus Villemoes
2021-06-15 13:36 ` Punit Agrawal
2021-06-16 6:56 ` Petr Mladek
2021-06-16 7:21 ` Petr Mladek
2021-06-16 7:51 ` John Ogness
2021-06-16 9:15 ` Petr Mladek
2021-06-16 13:52 ` Punit Agrawal
2021-06-16 1:30 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMlUOdpMEnTd2RSs@google.com \
--to=senozhatsky@chromium.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=punitagrawal@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox