The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Johannes Thumshirn <morbidrsa@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] mcb: Use DEFINE_RES_MEM() to simplify code
Date: Wed, 16 Jun 2021 08:41:05 +0200	[thread overview]
Message-ID: <YMmdAQtPN7QRfcNO@kroah.com> (raw)
In-Reply-To: <20210616015509.672-2-thunder.leizhen@huawei.com>

On Wed, Jun 16, 2021 at 09:55:09AM +0800, Zhen Lei wrote:
> Use DEFINE_RES_MEM() to save a couple of lines of code, which makes the
> code a bit shorter and easier to read. The start address does not need to
> appear twice.
> 
> By the way, the value of '.end' should be "start + size - 1". So the
> previous writing should have omitted subtracted 1.

Does that mean the current code is wrong and this is a bugfix?  If so,
what commit id does this fix?

thanks,

greg k-h

  reply	other threads:[~2021-06-16  6:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  1:55 [PATCH v2 0/1] mcb: Use DEFINE_RES_MEM() to simplify code Zhen Lei
2021-06-16  1:55 ` [PATCH v2 1/1] " Zhen Lei
2021-06-16  6:41   ` Greg Kroah-Hartman [this message]
2021-06-16  6:57     ` Leizhen (ThunderTown)
2021-06-16  7:17       ` Greg Kroah-Hartman
2021-06-16  7:37         ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMmdAQtPN7QRfcNO@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=morbidrsa@gmail.com \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox