Re: [patch V2 22/52] x86/fpu: Rename copy_xregs_to_kernel() and copy_kernel_to_xregs()

Borislav Petkov
2021-06-17T12:48:28Z

On Mon, Jun 14, 2021 at 05:44:30PM +0200, Thomas Gleixner wrote:
> The function names for xsave[s]/xrstor[s] operations are horribly named and
> a permanent source of confusion.
>
> Rename:
> copy_xregs_to_kernel() to xsave_to_kernel()
> copy_kernel_to_xregs() to xrstor_from_kernel()

Yap, better.

I wonder if simply calling them xsave() and xrstor() won't make it
even easier. The to/from kernel thing is kinda weird. If we need
to differentiate where we're saving, we can call the user variants
"to/from_user" instead, like the copy_to_/from_user things...

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg