From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F5CC2B9F4 for ; Thu, 17 Jun 2021 18:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBE4F6112D for ; Thu, 17 Jun 2021 18:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233011AbhFQSSg (ORCPT ); Thu, 17 Jun 2021 14:18:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232809AbhFQSSa (ORCPT ); Thu, 17 Jun 2021 14:18:30 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04A2AC061760 for ; Thu, 17 Jun 2021 11:16:21 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id e1so3364342plh.8 for ; Thu, 17 Jun 2021 11:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KRi/QXe0LQzMi+6pLeInEK4KzKA0hEwqTLci8VnoWbw=; b=KbyM6iG9HXDNGfRNYStr2s8SyPWsQZtjPlPad/4hLqGHkDrCbaOZGleaLH7yVwgmnE ECfgkecSAKpwK/B66+nzo5bNna84QPwgFYhu7AmR3LnKnwV3WlgYZmTaVEAuCUbaEqk5 uClapizSWOCsf6X1YtOqZ+HiL0Z8/VmrFu6ZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KRi/QXe0LQzMi+6pLeInEK4KzKA0hEwqTLci8VnoWbw=; b=ZLdYk48h0/LjqVF27eU+EmUXRXLroymE7lY3SpmJEs5m5Qg9Niscsyy/Ciy2JZ/bpA ju0UArWv4yy439OePKU/Yk0CDRn3vCzrGsKIcfQWi5xNx53uM7PIL6ZFEvXhreHLvsUc JtaASo60b8Q1ZsFEFcquiZQ8fwyRHtTFlSnvulC6ALeY6asTTrEjhic+blMN0wIy8zRI kvk+/PLJKRpeacm43KZB8QvuIqPxRtVrMHpooE0xKXqixLV4ZwCUUackNbOEyv6Qbdif 0p33VwIa/vx1sSFfzaRpYHcBW0XdQmBLDHT2f3zC1pbNUvR39ugmD/H695ft06Vk4R2y Oa4Q== X-Gm-Message-State: AOAM53268JT9myYTzl7BH/Kw6V8E8oQKKeqohyIIXIsElP53x5yct6PU uyfr4TEQax1BXu7x0eNOoAz9Bg== X-Google-Smtp-Source: ABdhPJwyJh/y5CCBFcqljYWo6aGyOfV35EucM7MER7B58+2F4yHzGguVOx690nkwweau6nsqLwS7Vw== X-Received: by 2002:a17:90a:6001:: with SMTP id y1mr17085610pji.5.1623953780486; Thu, 17 Jun 2021 11:16:20 -0700 (PDT) Received: from localhost ([2620:15c:202:201:14b4:cd2e:dd64:19e8]) by smtp.gmail.com with UTF8SMTPSA id n8sm9069159pjo.1.2021.06.17.11.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 11:16:20 -0700 (PDT) Date: Thu, 17 Jun 2021 11:16:18 -0700 From: Matthias Kaehlcke To: Greg Kroah-Hartman , Masahiro Yamada Cc: Naresh Kamboju , Linux-Next Mailing List , open list , linux-usb@vger.kernel.or, lkft-triage@lists.linaro.org, Stephen Rothwell , linux-kbuild@vger.kernel.org Subject: Re: [next] [arm64] allmodconfig build failed - xhci-plat.c:427: undefined reference to `onboard_hub_destroy_pdevs' Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 17, 2021 at 03:45:57PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 17, 2021 at 07:09:15PM +0530, Naresh Kamboju wrote: > > The arm64 allmodconfig build failed on Linux next 20210617 tag due to > > the commit, > > > > c950686b382d ("usb: host: xhci-plat: Create platform device for > > onboard hubs in probe()") > > > > build error: > > ------------ > > aarch64-linux-gnu-ld: drivers/usb/host/xhci-plat.o: in function > > `xhci_plat_remove': > > drivers/usb/host/xhci-plat.c:427: undefined reference to > > `onboard_hub_destroy_pdevs' > > drivers/usb/host/xhci-plat.c:427:(.text+0x82c): relocation truncated > > to fit: R_AARCH64_CALL26 against undefined symbol > > `onboard_hub_destroy_pdevs' > > aarch64-linux-gnu-ld: drivers/usb/host/xhci-plat.o: in function > > `xhci_plat_probe': > > drivers/usb/host/xhci-plat.c:379: undefined reference to > > `onboard_hub_create_pdevs' > > drivers/usb/host/xhci-plat.c:379:(.text+0x131c): relocation truncated > > to fit: R_AARCH64_CALL26 against undefined symbol > > `onboard_hub_create_pdevs' > > make[1]: *** [Makefile:1252: vmlinux] Error 1 > > make[1]: Target '__all' not remade because of errors. > > make: *** [Makefile:222: __sub-make] Error 2 > > make: Target '__all' not remade because of errors. > > Matthias, this is due to your patch, yet-another config option mis-match > somewhere. Can you please fix it up? I can repro this with: make -j 16 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ KCONFIG_ALLCONFIG=arch/arm64/configs/defconfig allmodconfig kernel modules This results in: CONFIG_USB_XHCI_PLATFORM=y CONFIG_USB_ONBOARD_HUB=m The following Kconfig dependency was supposed to prevent this scenario: config USB_XHCI_PLATFORM depends on USB_ONBOARD_HUB || !USB_ONBOARD_HUB But apparently this isn't the case. With the above allmodconfig command the following warning is emitted: WARNING: unmet direct dependencies detected for USB_XHCI_PLATFORM Depends on [m]: USB_SUPPORT [=y] && USB [=y] && USB_XHCI_HCD [=y] && (USB_ONBOARD_HUB [=m] || !USB_ONBOARD_HUB [=m]) I read through kconfig-language.rst multiple times, but it's still not clear to me how to specify this dependency properly. Masahiro/Greg, do you have any pointers?