From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C905BC49361 for ; Fri, 18 Jun 2021 11:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B32D6613D6 for ; Fri, 18 Jun 2021 11:10:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233879AbhFRLM5 (ORCPT ); Fri, 18 Jun 2021 07:12:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:54300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233945AbhFRLMr (ORCPT ); Fri, 18 Jun 2021 07:12:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E6ECB613F0; Fri, 18 Jun 2021 11:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624014638; bh=CdguOQI+emj8SVk0FNefXNuFORyKtszKhLiVCslTlec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E81WjeaYSfMCTG/7DquU/p6Klq6UIQ1aCP4VuxXSvw55qiFIudIjpKJIFguUuMBdU L7s2gMrqelHDVlUeYV0z7EotJPMuWUPBEUJ8jgGBwxRNfmil1s0vZKnIgLVYgUSkKB G04uPO1cRUtK6P8s/gSTV0uNB92oT9qfwQwTObuU= Date: Fri, 18 Jun 2021 13:10:35 +0200 From: Greg KH To: Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/69] mxser: cleanup Message-ID: References: <20210618061516.662-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618061516.662-1-jslaby@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 08:14:06AM +0200, Jiri Slaby wrote: > I was given a few cards from MOXA (thanks a lot). So I cleaned up the > driver and can continue maintaining it. > > A long term goal is to convert the driver to serial_core. > > Jiri Slaby (70): > mxser: drop ISA support > mxser: renumber mxser_cards > mxser: remove info printout from init > mxser: integrate mxser.h into .c > mxser: cleanup Gpci_uart_info struct > mxser: rename CheckIsMoxaMust to mxser_get_must_hwid > mxser: rename mxser_board::chip_flag to must_hwid > mxser: introduce enum mxser_must_hwid > mxser: drop constant board::uart_type > mxser: move max_baud from port to board > mxser: remove nonsense from ISR > mxser: cleanup LSR handling in mxser_receive_chars > mxser: extract port ISR > mxser: simplify mxser_interrupt and drop mxser_board::vector_mask > mxser: extract mxser_receive_chars_new > mxser: extract mxser_receive_chars_old > mxser: remove else from LSR bits checks > mxser: correct types for uart variables > mxser: make xmit ring buffer variables unsigned > mxser: drop UART_MCR_AFE and UART_LSR_SPECIAL defines > mxser: drop unused MOXA_DIAGNOSE macro > mxser: remove MOXA_GET_MAJOR deprecated ioctl > mxser: remove MOXA_SET_BAUD_METHOD ioctl > mxser: remove MOXA_ASPP_MON and friends > mxser: remove MOXA_ASPP_LSTATUS ioctl > mxser: remove MOXA_CHKPORTENABLE ioctl > mxser: remove MOXA_GETDATACOUNT ioctl > mxser: remove MOXA_GETMSTATUS ioctl > mxser: remove MOXA_ASPP_OQUEUE ioctl > mxser: remove MOXA_HighSpeedOn ioctl > mxser: remove cnt from mxser_receive_chars > mxser: don't allocate MXSER_PORTS + 1 > mxser: drop unused mxser_port::normal_termios > mxser: remove unused mxser_port::stop_rx > mxser: drop mxser_port::baud_base > mxser: drop mxser_port::custom_divisor > mxser: cleanup mxser_change_speed > mxser: extract mxser_ioctl_op_mode > mxser: simplify mxser_ioctl_op_mode > mxser: dedup mxser_must_set_enhance_mode > mxser: introduce mxser_must_select_bank and use it > mxser: clean up the rest of MUST helpers > mxser: move board init into mxser_initbrd > mxser: inline mxser_board_remove into mxser_remove > mxser: pci, switch to managed resources > mxser: move request irq to probe and switch to managed > mxser: remove info message from probe > mxser: remove mxser_cardinfo > mxser: cleanup mxser_process_txrx_fifo > mxser: rework and simplify mxser_open > mxser: make mxser_board::idx really an index > mxser: alloc struct mxser_board dynamically > mxser: alloc only needed # of ports > mxser: remove pointless ioaddr checks > mxser: cleanup mxser_rs_break > mxser: cleanup mxser_dtr_rts > mxser: don't start TX from tty_operations::put_char > mxser: extract and dedup CTS handling > mxser: introduce and use start/stop_tx helpers > mxser: remove xmit_cnt < 0 tests > mxser: decrypt FCR values > mxser: fix typos around enhanced mode > mxser: access info->MCR under info->slock > mxser: use port variable in mxser_set_serial_info > mxser: rename flags to old_speed in mxser_set_serial_info > mxser: introduce mxser_16550A_or_MUST helper > mxser: Documentation, remove traces of callout device > mxser: Documentation, make the docs up-to-date > mxser: Documentation, fix typos > MAINTAINERS: add me back as mxser maintainer > > .../driver-api/serial/moxa-smartio.rst | 496 +---- > MAINTAINERS | 3 +- > drivers/tty/Kconfig | 2 +- > drivers/tty/mxser.c | 1950 +++++------------ > drivers/tty/mxser.h | 151 -- > 5 files changed, 622 insertions(+), 1980 deletions(-) > delete mode 100644 drivers/tty/mxser.h Nice cleanups, thanks for doing this! greg k-h