From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91840C11F69 for ; Thu, 1 Jul 2021 00:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BF2B61425 for ; Thu, 1 Jul 2021 00:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238262AbhGAAut (ORCPT ); Wed, 30 Jun 2021 20:50:49 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39744 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236734AbhGAAus (ORCPT ); Wed, 30 Jun 2021 20:50:48 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1610m5Do030908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 20:48:05 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id DB01315C3C8E; Wed, 30 Jun 2021 20:48:04 -0400 (EDT) Date: Wed, 30 Jun 2021 20:48:04 -0400 From: "Theodore Ts'o" To: Josh Triplett Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Dilger Subject: Re: [PATCH 1/2] fs: ext4: Consolidate checks for resize of bigalloc into ext4_resize_begin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 10:23:15AM -0400, Theodore Ts'o wrote: > On Mon, Jun 07, 2021 at 12:15:08PM -0700, Josh Triplett wrote: > > Two different places checked for attempts to resize a filesystem with > > the bigalloc feature. Move the check into ext4_resize_begin, which both > > places already call. > > > > Signed-off-by: Josh Triplett > > Applied, thanks. I'm going to have to revert this change, since it breaks online resizing for bigalloc file system. The issue is that ext4_resize_begin() is called from *three* places: for EXT4_IOC_GROUP_ADD, EXT4_IOC_GROUP_EXTEND, and EXT4_IOC_RESIZE_FS. The first two ioctls are used for the "old-style" online resize, and bigalloc is not supported for those two ioctls. However, it *is* supposed to work for EXT4_IOC_RESIZE_FS. Unfortunately, this just caused some tests to be skipped (assuming that this was an old kernel that didn't support this feature) and I didn't notice it right away. - Ted