Re: [PATCH v3 3/6] dt-bindings: media: mt9p031: Add missing required properties

Stefan Riedmüller
2021-07-05T15:00:57Z

Hi Laurent,

On Fri, 2021-07-02 at 16:15 +0300, Laurent Pinchart wrote:
> Hi Stefan,
>
> Thank you for the patch.
>
> On Fri, Jul 02, 2021 at 11:59:19AM +0200, Stefan Riedmueller wrote:
> > Add missing required clocks and supply regulator properties for the
> > sensor input clock and vdd, vdd_io and vaa supply regulators.
>
> Can I volunteer you to convert these bindings to YAML first, and add the
> properties on top ? :-)

Sure, I can give it a try :-)

Regards,
Stefan

>
> > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> > ---
> > .../devicetree/bindings/media/i2c/mt9p031.txt | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > index cb60443ff78f..4437d0e3147d 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > @@ -9,6 +9,12 @@ Required Properties:
> > (a) "aptina,mt9p031" for mt9p031 sensor
> > (b) "aptina,mt9p031m" for mt9p031m sensor
> >
> > +- clocks: Reference to the sensor input clock
> > +
> > +- vdd-supply: VDD supply regulator
> > +- vdd_io-supply: VDD_IO supply regulator
> > +- vaa-supply: VAA supply regulator
> > +
> > - input-clock-frequency: Input clock frequency.
> >
> > - pixel-clock-frequency: Pixel clock frequency.
> > @@ -29,6 +35,12 @@ Example:
> > reg = <0x5d>;
> > reset-gpios = <&gpio3 30 0>;
> >
> > + clocks = <&sensor_clk>;
> > +
> > + vdd-supply = <&reg_vdd>;
> > + vdd_io-supply = <&reg_vdd_io>;
> > + vaa-supply = <&reg_vaa>;
> > +
> > port {
> > mt9p031_1: endpoint {
> > input-clock-frequency = <6000000>;