From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6E5C48BE5 for ; Mon, 21 Jun 2021 06:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6AA261040 for ; Mon, 21 Jun 2021 06:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhFUGfa (ORCPT ); Mon, 21 Jun 2021 02:35:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:33814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFUGf3 (ORCPT ); Mon, 21 Jun 2021 02:35:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E3ADD61003; Mon, 21 Jun 2021 06:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624257195; bh=4CHyizIg9hIDQpvR1sUF6YvkzCW5f0Mg81yRETpYfxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kkq/6Ie9xmSIeYZ0BVM7Kn12lEiK5wWTTUy2Odxg1XrCVA+Q+hve3E65qUukWEYUe C8Dl6tQm6Rol0GPks9qonx7BJW/+0hqC5DdNEXmxJZ6AsGqeRwefPV/gX370AQemD3 0uNSntOyUmMJiY8Sztli/cHhWZcb1Z1AfFmIB20chdT3s2wYxMr7ErNKHnPXqczFsH HU2l7bp3nonEjEipvrdzq013S10bwUrXSagUO8w8CzNWXBpcYAEE5cCC/FhqIc/YSV Vdl3DxaXC2mQpVvkpTDBGTsfFqKnf0Ig5T55bG9lQKL3etV57yzSjk3RV/HIerC2CX tHIn22z54zpvg== Date: Mon, 21 Jun 2021 12:03:12 +0530 From: Vinod Koul To: Kunihiko Hayashi Cc: Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar Subject: Re: [PATCH] phy: uniphier-pcie: Fix updating phy parameters Message-ID: References: <1623037842-19363-1-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623037842-19363-1-git-send-email-hayashi.kunihiko@socionext.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-06-21, 12:50, Kunihiko Hayashi wrote: > The current driver uses a value from register TEST_O as the original > value for register TEST_I, though, the value is overwritten by "param", > so there is a bug that the original value isn't no longer used. > > The value of TEST_O[7:0] should be masked with "mask", replaced with > "param", and placed in the bitfield TESTI_DAT_MASK as new TEST_I value. Applied, thanks -- ~Vinod