From: Andrew Lunn <andrew@lunn.ch>
To: Jian-Hong Pan <jhp@endlessos.org>
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@endlessos.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] net: bcmgenet: Fix attaching to PYH failed on RPi 4B
Date: Mon, 21 Jun 2021 15:09:06 +0200 [thread overview]
Message-ID: <YNCPcmEPuwdwoLto@lunn.ch> (raw)
In-Reply-To: <20210621103310.186334-1-jhp@endlessos.org>
On Mon, Jun 21, 2021 at 06:33:11PM +0800, Jian-Hong Pan wrote:
> The Broadcom UniMAC MDIO bus comes too late. So, GENET cannot find the
> ethernet PHY on UniMAC MDIO bus. This leads GENET fail to attach the
> PHY.
>
> bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
> ...
> could not attach to PHY
> bcmgenet fd580000.ethernet eth0: failed to connect to PHY
> uart-pl011 fe201000.serial: no DMA platform data
> libphy: bcmgenet MII bus: probed
> ...
> unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus
>
> This patch makes GENET try to connect the PHY up to 3 times. Also, waits
> a while between each time for mdio-bcm-unimac module's loading and
> probing.
Don't loop. Return -EPROBE_DEFER. The driver core will then probed the
driver again later, by which time, the MDIO bus driver should of
probed.
Andrew
next prev parent reply other threads:[~2021-06-21 13:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 10:33 [PATCH] net: bcmgenet: Fix attaching to PYH failed on RPi 4B Jian-Hong Pan
2021-06-21 13:09 ` Andrew Lunn [this message]
2021-06-21 16:37 ` Florian Fainelli
2021-06-21 16:47 ` Florian Fainelli
2021-06-21 16:56 ` Peter Robinson
2021-06-21 20:15 ` Stefan Wahren
2021-06-21 21:47 ` Florian Fainelli
2021-06-22 6:29 ` Jian-Hong Pan
2021-06-22 6:50 ` Heiner Kallweit
2021-06-22 7:46 ` Jian-Hong Pan
2021-06-23 3:28 ` [PATCH v2] " Jian-Hong Pan
2021-06-23 4:00 ` Florian Fainelli
2021-06-23 20:50 ` patchwork-bot+netdevbpf
2021-06-23 21:19 ` Florian Fainelli
2021-06-24 2:47 ` Jian-Hong Pan
2021-06-24 3:27 ` Florian Fainelli
2021-06-24 3:28 ` Jian-Hong Pan
2021-06-24 3:22 ` [PATCH v3] net: bcmgenet: Add mdio-bcm-unimac soft dependency Jian-Hong Pan
2021-06-24 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNCPcmEPuwdwoLto@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jhp@endlessos.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@endlessos.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox