From: Greg KH <gregkh@linuxfoundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: rafael@kernel.org, jeyu@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, minchan@kernel.org,
axboe@kernel.dk, mbenes@suse.com, jpoimboe@redhat.com,
tglx@linutronix.de, keescook@chromium.org, jikos@kernel.org,
rostedt@goodmis.org, peterz@infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/base/core: refcount kobject and bus on device attribute read / store
Date: Tue, 22 Jun 2021 23:34:52 +0200 [thread overview]
Message-ID: <YNJXfNfn4+CaKOyz@kroah.com> (raw)
In-Reply-To: <20210622210659.3708231-1-mcgrof@kernel.org>
On Tue, Jun 22, 2021 at 02:06:59PM -0700, Luis Chamberlain wrote:
> static ssize_t dev_attr_show(struct kobject *kobj, struct attribute *attr,
> char *buf)
> {
> - struct device_attribute *dev_attr = to_dev_attr(attr);
> - struct device *dev = kobj_to_dev(kobj);
> + struct device_attribute *dev_attr;
> + struct device *dev;
> + struct bus_type *bus = NULL;
> ssize_t ret = -EIO;
>
> + dev = get_device(kobj_to_dev(kobj));
> + if (!dev)
> + return ret;
That check is impossible to ever hit, please recognize what things like
kobj_to_dev() really are doing when calling it.
thanks,
greg k-h
prev parent reply other threads:[~2021-06-22 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 21:06 [PATCH] drivers/base/core: refcount kobject and bus on device attribute read / store Luis Chamberlain
2021-06-22 21:32 ` Greg KH
2021-06-22 21:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNJXfNfn4+CaKOyz@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox