public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Saubhik Mukherjee <saubhik.mukherjee@gmail.com>
Cc: vgupta@synopsys.com, Jiri Slaby <jirislaby@kernel.org>,
	linux-snps-arc@lists.infradead.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org,
	Pavel Andrianov <andrianov@ispras.ru>
Subject: Re: [question] De-registration does not remove port
Date: Wed, 23 Jun 2021 09:14:56 +0200	[thread overview]
Message-ID: <YNLfcKFL1LkJgXAR@kroah.com> (raw)
In-Reply-To: <3e131267-e1b3-1b83-f8be-0577da479223@gmail.com>

On Wed, Jun 23, 2021 at 11:42:36AM +0530, Saubhik Mukherjee wrote:
> In drivers/tty/serial/arc_uart.c, arc_serial_remove always returns 0,
> instead of calling uart_remove_one_port to remove uart port from serial
> core. The comment says "This will be never be called". In my understanding,
> a port added using uart_add_one_port should be removed during
> de-registration.
> 
> Is there a reason for this behavior?

Did you test the code to see if that function will ever be called?

thanks,

greg k-h

  reply	other threads:[~2021-06-23  7:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  6:12 [question] De-registration does not remove port Saubhik Mukherjee
2021-06-23  7:14 ` Greg KH [this message]
2021-06-24 13:03   ` Saubhik Mukherjee
2021-06-24 13:07     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNLfcKFL1LkJgXAR@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andrianov@ispras.ru \
    --cc=jirislaby@kernel.org \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=saubhik.mukherjee@gmail.com \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox