From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD555C48BC2 for ; Wed, 23 Jun 2021 07:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95EBD6102A for ; Wed, 23 Jun 2021 07:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbhFWHRR (ORCPT ); Wed, 23 Jun 2021 03:17:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:54394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbhFWHRQ (ORCPT ); Wed, 23 Jun 2021 03:17:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C0726023B; Wed, 23 Jun 2021 07:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624432499; bh=BIJkp+bmcpYoUNpthePnxTk/99MSKXjR1s8U+gXPqxY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJZy04Xz4F2KocY6sOqVmz2/2kcEzHRoPOXKtLIXZYqL4KEB0Gue3K73R7IQ6oqzU yvRzpo2jY0kwfpGwoWFnyrp7p0Je001Zg4draSJNUs/iewNdKQUOEQx9/uPJbgetR+ 5fjruXQ2RunUdpVoFKbzr0UZb/Ru9UTJFv1QdM7c= Date: Wed, 23 Jun 2021 09:14:56 +0200 From: Greg KH To: Saubhik Mukherjee Cc: vgupta@synopsys.com, Jiri Slaby , linux-snps-arc@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, Pavel Andrianov Subject: Re: [question] De-registration does not remove port Message-ID: References: <3e131267-e1b3-1b83-f8be-0577da479223@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e131267-e1b3-1b83-f8be-0577da479223@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2021 at 11:42:36AM +0530, Saubhik Mukherjee wrote: > In drivers/tty/serial/arc_uart.c, arc_serial_remove always returns 0, > instead of calling uart_remove_one_port to remove uart port from serial > core. The comment says "This will be never be called". In my understanding, > a port added using uart_add_one_port should be removed during > de-registration. > > Is there a reason for this behavior? Did you test the code to see if that function will ever be called? thanks, greg k-h