From: Greg KH <gregkh@linuxfoundation.org>
To: Zhenguo Zhao <zhenguo6858@gmail.com>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: n_gsm: modify the doc punctuation "," to "."
Date: Thu, 24 Jun 2021 14:59:59 +0200 [thread overview]
Message-ID: <YNSBz60hC2Czy95I@kroah.com> (raw)
In-Reply-To: <1623981811-19505-1-git-send-email-zhenguo6858@gmail.com>
On Fri, Jun 18, 2021 at 10:03:31AM +0800, Zhenguo Zhao wrote:
> From: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
>
> End punctuation of items 5 and 6 are ".",other lists
> should be modify to "."
>
> Signed-off-by: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
> ---
> Documentation/driver-api/serial/n_gsm.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/driver-api/serial/n_gsm.rst b/Documentation/driver-api/serial/n_gsm.rst
> index 87dfcd5..154c75e 100644
> --- a/Documentation/driver-api/serial/n_gsm.rst
> +++ b/Documentation/driver-api/serial/n_gsm.rst
> @@ -14,11 +14,11 @@ How to use it
> -------------
> 1. initialize the modem in 0710 mux mode (usually AT+CMUX= command) through
> its serial port. Depending on the modem used, you can pass more or less
> - parameters to this command,
> + parameters to this command.
> 2. switch the serial line to using the n_gsm line discipline by using
> - TIOCSETD ioctl,
> -3. configure the mux using GSMIOC_GETCONF / GSMIOC_SETCONF ioctl,
> -4. obtain base gsmtty number for the used serial port,
> + TIOCSETD ioctl.
> +3. configure the mux using GSMIOC_GETCONF / GSMIOC_SETCONF ioctl.
> +4. obtain base gsmtty number for the used serial port.
>
Strangly, the use of a ',' here is correct as this is a list of things
to do in a specific order. If you wrote this all out at once in a
single sentance without the numbers, a ',' would make sense.
But this isn't a big deal, if you want to use '.' then please capitalize
the first word of each item in the list.
Picky, yes, sorry.
greg k-h
prev parent reply other threads:[~2021-06-24 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 2:03 [PATCH] tty: n_gsm: modify the doc punctuation "," to "." Zhenguo Zhao
2021-06-24 12:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNSBz60hC2Czy95I@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhenguo6858@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox