Re: [PATCH v2] i2c: core: Disable client irq on reboot/shutdown

Dmitry Torokhov
2021-06-05T22:54:53Z

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> ---
>
> Dmitry, please add Signed-off-by so this can be merged through i2c
>
> This supersedes https://lore.kernel.org/r/20210510220012.2003285-1-swboyd@chromium.org
>
> Changes from v1 (https://lore.kernel.org/r/20210604212752.3547301-1-swboyd@chromium.org)
> * Add interrupt.h include for robot
>
> drivers/i2c/i2c-core-base.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index 5a97e4a02fa2..e314ccaf114a 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -24,6 +24,7 @@
> #include <linux/i2c-smbus.h>
> #include <linux/idr.h>
> #include <linux/init.h>
> +#include <linux/interrupt.h>
> #include <linux/irqflags.h>
> #include <linux/jump_label.h>
> #include <linux/kernel.h>
> @@ -627,6 +628,8 @@ static void i2c_device_shutdown(struct device *dev)
> driver = to_i2c_driver(dev->driver);
> if (driver->shutdown)
> driver->shutdown(client);
> + else if (client->irq > 0)
> + disable_irq(client->irq);
> }
>
> static void i2c_client_dev_release(struct device *dev)
>
> base-commit: 8124c8a6b35386f73523d27eacb71b5364a68c4c
> --
> https://chromeos.dev
>

--
Dmitry