From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A824C2B9F4 for ; Sat, 26 Jun 2021 02:37:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D24AD61963 for ; Sat, 26 Jun 2021 02:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbhFZCj4 (ORCPT ); Fri, 25 Jun 2021 22:39:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbhFZCjz (ORCPT ); Fri, 25 Jun 2021 22:39:55 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258ECC061574 for ; Fri, 25 Jun 2021 19:37:34 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwyCC-00CKWy-L1; Sat, 26 Jun 2021 02:37:24 +0000 Date: Sat, 26 Jun 2021 02:37:24 +0000 From: Al Viro To: Linus Torvalds Cc: Andrew Morton , Alexey Dobriyan , Linux Kernel Mailing List , Miguel Ojeda Subject: Re: [PATCH v2] ELF: add and use SUPPRESS_WARN_UNUSED_RESULT Message-ID: References: <20210625163040.a15af04872959da9af161fca@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 25, 2021 at 07:05:58PM -0700, Linus Torvalds wrote: > > Do we really care about userspace which relies upon an SVR4 quirk? I > > guess it's too hard to prove the no case, so it stays. > > I think we can safely remove it. Doing a mmap() at address zero will > not actually work anyway in any half-way modern Linux environment. > > And I think the "map zeroes at NULL" wasn't even universal for SVr4. > _Some_ binaries may have expected it, but I suspect it was the > exception rather than the rule. > > So I'd happily take a patch that just removes it. If nothing else, it > would be trivial to put back if somebody screams, but I seriously > doubt that is going to happen. Wasn't there some emulator (dosemu? wine?) that relied upon that? Said that, I could be easily wrong - half-asleep right now...