From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0FBC2B9F4 for ; Mon, 28 Jun 2021 15:31:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B9FF6198E for ; Mon, 28 Jun 2021 15:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236013AbhF1Pde (ORCPT ); Mon, 28 Jun 2021 11:33:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:39694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235907AbhF1PH3 (ORCPT ); Mon, 28 Jun 2021 11:07:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2035061206; Mon, 28 Jun 2021 14:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624892055; bh=/c6iu5WfXHrHMg2iHXxJCvUhPZ5Ltwmg43YDMEHHhms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wl5r73Lz+qhMKIksyfSe6Ryt7bvj3NhSo7lQSAt+hvGs69P5CL+PqJqN8Pg33w101 Pilf1iA7uPnDpXDsYCXm34HS9/peuHvLuGMwHTxI37WU1J/VpVlXF0uXjRmafzTA2r obu4bEr4ZTCj0Bi6uiMTOf9WZ+p5Iyf5g8+JenkI= Date: Mon, 28 Jun 2021 16:54:13 +0200 From: Greg KH To: Eric Auger Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, mihai.carabas@oracle.com, arnd@arndb.de, pizhenwei@bytedance.com, andriy.shevchenko@linux.intel.com, pbonzini@redhat.com, joe@perches.com Subject: Re: [PATCH] misc/pvpanic-pci: Allow automatic loading Message-ID: References: <20210628144422.895526-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628144422.895526-1-eric.auger@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote: > The pvpanic-pci driver does not auto-load and requires manual > modprobe. Let's include a device database using the > MODULE_DEVICE_TABLE macro. > > Signed-off-by: Eric Auger > --- > drivers/misc/pvpanic/pvpanic-pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c > index 9ecc4e8559d5d..30290d42d8aa8 100644 > --- a/drivers/misc/pvpanic/pvpanic-pci.c > +++ b/drivers/misc/pvpanic/pvpanic-pci.c > @@ -122,4 +122,6 @@ static struct pci_driver pvpanic_pci_driver = { > }, > }; > > +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl); > + Is this something that you need? Or is it created by a tool? thanks, greg k-h