From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF540C2B9F4 for ; Mon, 28 Jun 2021 17:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A2C3619A1 for ; Mon, 28 Jun 2021 17:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232963AbhF1RLI (ORCPT ); Mon, 28 Jun 2021 13:11:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:65358 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232010AbhF1RLD (ORCPT ); Mon, 28 Jun 2021 13:11:03 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="195147999" X-IronPort-AV: E=Sophos;i="5.83,306,1616482800"; d="scan'208";a="195147999" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 10:08:37 -0700 X-IronPort-AV: E=Sophos;i="5.83,306,1616482800"; d="scan'208";a="488960331" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 10:08:34 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1lxukI-0065KS-9v; Mon, 28 Jun 2021 20:08:30 +0300 Date: Mon, 28 Jun 2021 20:08:30 +0300 From: Andy Shevchenko To: Eric Auger Cc: Greg KH , eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, mihai.carabas@oracle.com, arnd@arndb.de, pizhenwei@bytedance.com, pbonzini@redhat.com, joe@perches.com Subject: Re: [PATCH] misc/pvpanic-pci: Allow automatic loading Message-ID: References: <20210628144422.895526-1-eric.auger@redhat.com> <5e3f7609-4820-6a8b-306e-553f10ce0f8a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e3f7609-4820-6a8b-306e-553f10ce0f8a@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 05:44:13PM +0200, Eric Auger wrote: > On 6/28/21 4:54 PM, Greg KH wrote: > > On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote: > >> The pvpanic-pci driver does not auto-load and requires manual > >> modprobe. Let's include a device database using the > >> MODULE_DEVICE_TABLE macro. ... > > Is this something that you need? Or is it created by a tool? > > the virtual machine monitor (QEMU) exposes the pvpanic-pci device to the > guest. On guest side the module exists but currently isn't loaded > automatically. So the driver fails to be probed and does not its job of > handling guest panic events. We need a SW actor that loads the module > and I thought this should be handled that way. If not, please could you > advise? At least something like about should have been in the commit message. Otherwise the selling point is unclear. -- With Best Regards, Andy Shevchenko