public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <llong@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	linux-kernel@vger.kernel.org, "Xu,
	Yanfei" <yanfei.xu@windriver.com>
Subject: Re: [PATCH] locking/mutex: Reduce chance of setting HANDOFF bit on unlocked mutex
Date: Wed, 30 Jun 2021 15:56:49 +0200	[thread overview]
Message-ID: <YNx4IWfE/wpFFh0h@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <ecc0cc97-23ca-5de3-2a12-ed50aa12548c@redhat.com>

On Wed, Jun 30, 2021 at 09:50:11AM -0400, Waiman Long wrote:

> The code looks good to me. It is an even better approach to make sure that
> the HANDOFF will never be set on an unlocked mutex.
> 
> Reviewed-by: Waiman Long <longman@redhat.com>

Thanks, what about that XXX? Should we not check sigpending before doing
the optimistic spinning thing?

  reply	other threads:[~2021-06-30 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 20:11 [PATCH] locking/mutex: Reduce chance of setting HANDOFF bit on unlocked mutex Waiman Long
2021-06-30 10:21 ` Peter Zijlstra
2021-06-30 13:50   ` Waiman Long
2021-06-30 13:56     ` Peter Zijlstra [this message]
2021-06-30 14:13       ` Waiman Long
2021-06-30 14:46         ` Peter Zijlstra
2021-06-30 14:43   ` Xu, Yanfei
2021-06-30 14:50     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNx4IWfE/wpFFh0h@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=mingo@redhat.com \
    --cc=will@kernel.org \
    --cc=yanfei.xu@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox