Re: [PATCH mfd v3] mfd: Add Renesas Synchronization Management Unit (SMU) support

Lee Jones
2021-07-13T11:21:45Z

On Fri, 18 Jun 2021, min.li.xe@renesas.com wrote:

> From: Min Li <min.li.xe@renesas.com>
>
> Add support for ClockMatrix(TM) and 82P33xxx families of timing
> and synchronization devices. The access interface can be either
> SPI or I2C. Currently, it will create 2 types of MFD devices,
> which are to be used by the corresponding rsmu character device
> driver and the PTP hardware clock driver, respectively.
>
> Signed-off-by: Min Li <min.li.xe@renesas.com>
> ---
> Change log
> -create the core driver suggested by Lee Jones
> -export rsmu_ddata instead of platform_data suggested by Lee Jones
> -add support for 8v19n85x chips
>
> drivers/mfd/Kconfig | 28 ++
> drivers/mfd/Makefile | 5 +
> drivers/mfd/rsmu.h | 16 +
> drivers/mfd/rsmu_core.c | 88 +++++
> drivers/mfd/rsmu_i2c.c | 203 +++++++++++
> drivers/mfd/rsmu_spi.c | 273 +++++++++++++++
> include/linux/mfd/idt82p33_reg.h | 112 ++++++
> include/linux/mfd/idt8a340_reg.h | 729 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/rsmu.h | 36 ++
> 9 files changed, 1490 insertions(+)
> create mode 100644 drivers/mfd/rsmu.h
> create mode 100644 drivers/mfd/rsmu_core.c
> create mode 100644 drivers/mfd/rsmu_i2c.c
> create mode 100644 drivers/mfd/rsmu_spi.c
> create mode 100644 include/linux/mfd/idt82p33_reg.h
> create mode 100644 include/linux/mfd/idt8a340_reg.h
> create mode 100644 include/linux/mfd/rsmu.h

Thanks for sticking with this. I still have a couple of minor
niggles, but they'll be fixed over time.

Applied, thanks.