RE: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references

Andrew Gabbasov
2021-07-11T16:45:29Z

Hello Greg,

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Sunday, July 11, 2021 7:07 PM
> To: Gabbasov, Andrew <Andrew_Gabbasov@mentor.com>
> Cc: Macpaul Lin <macpaul.lin@mediatek.com>; Eugeniu Rosca <erosca@de.adit-jv.com>; linux-usb@vger.kernel.org;
> linux-kernel@vger.kernel.org; stable@vger.kernel.org; Felipe Balbi <balbi@kernel.org>; Eugeniu Rosca
> <roscaeugeniu@gmail.com>; Eddie Hung <eddie.hung@mediatek.com>
> Subject: Re: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references
>
> On Sun, Jul 11, 2021 at 10:51:30AM -0500, Andrew Gabbasov wrote:
> > commit ecfbd7b9054bddb12cea07fda41bb3a79a7b0149 upstream.
> >

[ skipped ]

> > Fixes: 4b187fceec3c ("usb: gadget: FunctionFS: add devices management code")
> > Fixes: 3262ad824307 ("usb: gadget: f_fs: Stop ffs_closed NULL pointer dereference")
> > Fixes: cdafb6d8b8da ("usb: gadget: f_fs: Fix use-after-free in ffs_free_inst")
> > Reported-by: Bhuvanesh Surachari <bhuvanesh_surachari@mentor.com>
> > Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > Reviewed-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> > Link: https://lore.kernel.org/r/20210603171507.22514-1-andrew_gabbasov@mentor.com
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > [agabbasov: Backported to earlier mount API, resolved context conflicts]
> > ---
> > drivers/usb/gadget/function/f_fs.c | 67 ++++++++++++++----------------
> > 1 file changed, 32 insertions(+), 35 deletions(-)
>
> I also need a 4.19 version of this commit, as you do not want to upgrade
> to a newer kernel and regress. Can you also provide that?

If I correctly understand, this particular file has a very minor difference
between 4.14 and 4.19. So, this same patch for 4.14 can be just applied / cherry-picked
cleanly on top of latest stable 4.19.

Thanks!

Best regards,
Andrew